Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Issue 11238035: Make isEmpty a getter. (Closed)

Created:
8 years, 2 months ago by floitsch
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org, Florian Schneider
Visibility:
Public.

Description

Make isEmpty a getter. Committed: https://code.google.com/p/dart/source/detail?r=14022

Patch Set 1 #

Patch Set 2 : Reupload #

Patch Set 3 : Reupload #

Patch Set 4 : Reupload #

Patch Set 5 : Update status file with co19 issue number. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+876 lines, -737 lines) Patch
M compiler/javatests/com/google/dart/compiler/parser/StringBuffer.dart View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/formatter/testsource/test004$A_in.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/formatter/testsource/test004$A_out.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/testsource/CoreRuntimeTypesTest.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/closure.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M lib/compiler/implementation/code_buffer.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/compile_time_constants.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M lib/compiler/implementation/dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/dart_backend/backend.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/dart_backend/utils.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/elements/elements.dart View 1 2 3 4 6 chunks +7 lines, -7 lines 0 comments Download
M lib/compiler/implementation/enqueue.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/js/printer.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/js_backend/emitter.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M lib/compiler/implementation/js_backend/namer.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/js_backend/native_emitter.dart View 8 chunks +13 lines, -13 lines 0 comments Download
M lib/compiler/implementation/lib/constant_map.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/lib/interceptors.dart View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/lib/isolate_patch.dart View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M lib/compiler/implementation/lib/js_helper.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/patch_parser.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/resolution/members.dart View 1 2 3 4 32 chunks +40 lines, -40 lines 0 comments Download
M lib/compiler/implementation/resolution/scope.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/runtime_types.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/scanner/array_based_scanner.dart View 6 chunks +9 lines, -9 lines 0 comments Download
M lib/compiler/implementation/scanner/byte_strings.dart View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/scanner/class_element_parser.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/scanner/keyword.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/scanner/listener.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M lib/compiler/implementation/scanner/parser.dart View 1 4 chunks +8 lines, -8 lines 0 comments Download
M lib/compiler/implementation/scanner/string_scanner.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/scanner/token.dart View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/ssa/bailout.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M lib/compiler/implementation/ssa/builder.dart View 1 2 3 4 38 chunks +42 lines, -42 lines 0 comments Download
M lib/compiler/implementation/ssa/codegen.dart View 9 chunks +11 lines, -11 lines 0 comments Download
M lib/compiler/implementation/ssa/codegen_helpers.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M lib/compiler/implementation/ssa/nodes.dart View 8 chunks +9 lines, -9 lines 0 comments Download
M lib/compiler/implementation/ssa/optimize.dart View 9 chunks +9 lines, -9 lines 0 comments Download
M lib/compiler/implementation/ssa/tracer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/ssa/types_propagation.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/ssa/validate.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/ssa/value_set.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/ssa/variable_allocator.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M lib/compiler/implementation/tools/mini_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/tree/dartstring.dart View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/tree/nodes.dart View 11 chunks +14 lines, -14 lines 0 comments Download
M lib/compiler/implementation/tree/prettyprint.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/tree/unparser.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M lib/compiler/implementation/tree_validator.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M lib/compiler/implementation/typechecker.dart View 1 12 chunks +16 lines, -16 lines 0 comments Download
M lib/compiler/implementation/types/concrete_types_inferrer.dart View 1 2 3 4 8 chunks +8 lines, -8 lines 0 comments Download
M lib/compiler/implementation/types/types.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M lib/compiler/implementation/universe/partial_type_tree.dart View 1 5 chunks +7 lines, -7 lines 0 comments Download
M lib/compiler/implementation/universe/selector_map.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M lib/compiler/implementation/universe/universe.dart View 9 chunks +11 lines, -11 lines 0 comments Download
M lib/compiler/implementation/util/link.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/util/link_implementation.dart View 1 2 3 4 5 chunks +9 lines, -9 lines 0 comments Download
M lib/compiler/implementation/world.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M lib/core/collection.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M lib/core/expect.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M lib/core/future.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/core/map.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/core/sequences.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M lib/core/string.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/core/string_buffer.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M lib/coreimpl/hash_map_set.dart View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M lib/coreimpl/linked_hash_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/coreimpl/queue.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M lib/coreimpl/splay_tree.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M lib/html/dart2js/html_dart2js.dart View 52 chunks +52 lines, -52 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 53 chunks +53 lines, -53 lines 0 comments Download
M lib/html/scripts/idlparser.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/scripts/idlrenderer.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M lib/html/src/native_DOMImplementation.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M lib/html/templates/immutable_list_mixin.darttemplate View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M lib/uri/helpers.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dartdoc/bin/dartdoc.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/dartdoc/lib/dartdoc.dart View 8 chunks +9 lines, -9 lines 0 comments Download
M pkg/dartdoc/lib/mirrors_util.dart View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/dartdoc/lib/src/client/dropdown.dart View 5 chunks +7 lines, -7 lines 0 comments Download
M pkg/dartdoc/lib/src/client/search.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/dartdoc/lib/src/dartdoc/comment_map.dart View 3 chunks +3 lines, -3 lines 0 comments Download
pkg/dartdoc/lib/src/markdown/html_renderer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/dartdoc/lib/src/mirrors/util.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/lib/date_format.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/lib/src/date_format_field.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/lib/src/date_format_helpers.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/core_matchers.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
runtime/bin/buffer_list.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/common.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/directory.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/file.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/http_impl.dart View 1 7 chunks +9 lines, -9 lines 0 comments Download
M runtime/bin/list_stream_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/path_impl.dart View 1 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/socket.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/socket_stream_impl.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/string_stream.dart View 1 11 chunks +12 lines, -12 lines 0 comments Download
M runtime/lib/array.dart View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/lib/byte_array.dart View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/lib/growable_array.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/immutable_map.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/integers.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/string_base.dart View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
runtime/tests/vm/dart/isolate_mirror_local_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_optimizer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 3 chunks +10 lines, -10 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M samples/buildhook2/build.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/markdown/html_renderer.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/DataSource.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/third_party/dromaeo/tests/dom-query-htmlidiomatic.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/ui_lib/base/AnimationScheduler.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/ui_lib/base/Size.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/ui_lib/observable/ChangeEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/ui_lib/observable/observable.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/ui_lib/touch/Momentum.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M tests/co19/co19-dart2dart.status View 1 2 3 4 1 chunk +46 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 3 4 1 chunk +46 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 3 4 1 chunk +47 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/begin_end_token_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/link_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/mirrors_test.dart View 9 chunks +13 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/parser_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/parser_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 14 chunks +28 lines, -28 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/unparser2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_extra/no_such_method_test.dart View 1 chunk +1 line, -1 line 0 comments Download
tests/compiler/dart2js_foreign/native_null_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_null_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/core_runtime_types_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/corelib/hash_map_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/corelib/list_iterators_test.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/list_test.dart View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M tests/corelib/reg_exp_all_matches_test.dart View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M tests/corelib/string_buffer_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/html/documentfragment_test.dart View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
M tests/html/element_classes_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/element_test.dart View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M tests/html/htmlcollection_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/htmlelement_test.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M tests/html/localstorage_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/node_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/query_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/xmldocument_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/html/xmlelement_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/language/compile_time_constant_a_test.dart View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M tests/language/compile_time_constant_b_test.dart View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/string_intrinsics_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/temp_mangling_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/directory_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_environment_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/test_runner_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M utils/apidoc/apidoc.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M utils/apidoc/html_diff.dart View 1 5 chunks +5 lines, -5 lines 0 comments Download
M utils/archive/options.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/peg/pegparser.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/command_help.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/command_update.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/git_source.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/io.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/pub.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/pub/pubspec.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/version_solver.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M utils/pub/yaml/yaml_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/template/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/test_pub.dart View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M utils/tests/pub/version_solver_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
8 years, 2 months ago (2012-10-24 12:39:17 UTC) #1
Florian Schneider
runtime/vm/* LGTM.
8 years, 2 months ago (2012-10-24 12:58:39 UTC) #2
Lasse Reichstein Nielsen
8 years, 2 months ago (2012-10-24 13:58:02 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698