Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: utils/tests/pub/test_pub.dart

Issue 11238035: Make isEmpty a getter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status file with co19 issue number. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/template/codegen.dart ('k') | utils/tests/pub/version_solver_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/test_pub.dart
diff --git a/utils/tests/pub/test_pub.dart b/utils/tests/pub/test_pub.dart
index 3e69cef007679ae886aefcf95314780924caecfe..69f257060c08c44f240698b3d9b0320266f28acd 100644
--- a/utils/tests/pub/test_pub.dart
+++ b/utils/tests/pub/test_pub.dart
@@ -872,7 +872,7 @@ class FileDescriptor extends Descriptor {
* Loads the contents of the file.
*/
InputStream load(List<String> path) {
- if (!path.isEmpty()) {
+ if (!path.isEmpty) {
var joinedPath = Strings.join(path, '/');
throw "Can't load $joinedPath from within $name: not a directory.";
}
@@ -943,7 +943,7 @@ class DirectoryDescriptor extends Descriptor {
* Loads [path] from within this directory.
*/
InputStream load(List<String> path) {
- if (path.isEmpty()) {
+ if (path.isEmpty) {
throw "Can't load the contents of $name: is a directory.";
}
@@ -1123,7 +1123,7 @@ class TarFileDescriptor extends Descriptor {
* Loads the contents of this tar file.
*/
InputStream load(List<String> path) {
- if (!path.isEmpty()) {
+ if (!path.isEmpty) {
var joinedPath = Strings.join(path, '/');
throw "Can't load $joinedPath from within $name: not a directory.";
}
@@ -1158,7 +1158,7 @@ class NothingDescriptor extends Descriptor {
}
InputStream load(List<String> path) {
- if (path.isEmpty()) {
+ if (path.isEmpty) {
throw "Can't load the contents of $name: it doesn't exist.";
} else {
throw "Can't load ${Strings.join(path, '/')} from within $name: $name "
« no previous file with comments | « utils/template/codegen.dart ('k') | utils/tests/pub/version_solver_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698