Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: lib/compiler/implementation/scanner/array_based_scanner.dart

Issue 11238035: Make isEmpty a getter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status file with co19 issue number. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/scanner/array_based_scanner.dart
diff --git a/lib/compiler/implementation/scanner/array_based_scanner.dart b/lib/compiler/implementation/scanner/array_based_scanner.dart
index 0e02b0d66681b1748d786ed456d3a70e8fbae377..986caf9fc8050661fbb7fc3f0489dbee1d7c2b27 100644
--- a/lib/compiler/implementation/scanner/array_based_scanner.dart
+++ b/lib/compiler/implementation/scanner/array_based_scanner.dart
@@ -65,7 +65,7 @@ class ArrayBasedScanner<S extends SourceString> extends AbstractScanner<S> {
// EOF points to itself so there's always infinite look-ahead.
tail.next = tail;
discardOpenLt();
- while (!groupingStack.isEmpty()) {
+ while (!groupingStack.isEmpty) {
BeginGroupToken begin = groupingStack.head;
begin.endGroup = tail;
groupingStack = groupingStack.tail;
@@ -104,7 +104,7 @@ class ArrayBasedScanner<S extends SourceString> extends AbstractScanner<S> {
assert(!identical(openKind, LT_TOKEN));
appendStringToken(info, value);
discardOpenLt();
- if (groupingStack.isEmpty()) {
+ if (groupingStack.isEmpty) {
return advance();
}
BeginGroupToken begin = groupingStack.head;
@@ -128,7 +128,7 @@ class ArrayBasedScanner<S extends SourceString> extends AbstractScanner<S> {
void appendGt(PrecedenceInfo info, String value) {
appendStringToken(info, value);
- if (groupingStack.isEmpty()) return;
+ if (groupingStack.isEmpty) return;
if (identical(groupingStack.head.kind, LT_TOKEN)) {
groupingStack.head.endGroup = tail;
groupingStack = groupingStack.tail;
@@ -137,11 +137,11 @@ class ArrayBasedScanner<S extends SourceString> extends AbstractScanner<S> {
void appendGtGt(PrecedenceInfo info, String value) {
appendStringToken(info, value);
- if (groupingStack.isEmpty()) return;
+ if (groupingStack.isEmpty) return;
if (identical(groupingStack.head.kind, LT_TOKEN)) {
groupingStack = groupingStack.tail;
}
- if (groupingStack.isEmpty()) return;
+ if (groupingStack.isEmpty) return;
if (identical(groupingStack.head.kind, LT_TOKEN)) {
groupingStack.head.endGroup = tail;
groupingStack = groupingStack.tail;
@@ -150,15 +150,15 @@ class ArrayBasedScanner<S extends SourceString> extends AbstractScanner<S> {
void appendGtGtGt(PrecedenceInfo info, String value) {
appendStringToken(info, value);
- if (groupingStack.isEmpty()) return;
+ if (groupingStack.isEmpty) return;
if (identical(groupingStack.head.kind, LT_TOKEN)) {
groupingStack = groupingStack.tail;
}
- if (groupingStack.isEmpty()) return;
+ if (groupingStack.isEmpty) return;
if (identical(groupingStack.head.kind, LT_TOKEN)) {
groupingStack = groupingStack.tail;
}
- if (groupingStack.isEmpty()) return;
+ if (groupingStack.isEmpty) return;
if (identical(groupingStack.head.kind, LT_TOKEN)) {
groupingStack.head.endGroup = tail;
groupingStack = groupingStack.tail;
@@ -172,7 +172,7 @@ class ArrayBasedScanner<S extends SourceString> extends AbstractScanner<S> {
}
void discardOpenLt() {
- while (!groupingStack.isEmpty()
+ while (!groupingStack.isEmpty
&& identical(groupingStack.head.kind, LT_TOKEN)) {
groupingStack = groupingStack.tail;
}
« no previous file with comments | « lib/compiler/implementation/runtime_types.dart ('k') | lib/compiler/implementation/scanner/byte_strings.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698