Make isEmpty a getter.

lib/compiler/implementation/universe/universe.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library universe;
 
 import '../closure.dart';
 import '../elements/elements.dart';
 import '../dart2jslib.dart';
 import '../runtime_types.dart';
@@ skipping 118 matching lines @@
 
   Selector(
       this.kind,
       SourceString name,
       LibraryElement library,
       this.argumentCount,
       [List<SourceString> namedArguments = const <SourceString>[]])
     : this.name = name,
       this.library = name.isPrivate() ? library : null,
       this.namedArguments = namedArguments,
-      this.orderedNamedArguments = namedArguments.isEmpty()
+      this.orderedNamedArguments = namedArguments.isEmpty
           ? namedArguments
           : <SourceString>[] {
     assert(!name.isPrivate() || library != null);
   }
 
   Selector.getter(SourceString name, LibraryElement library)
       : this(SelectorKind.GETTER, name, library, 0);
 
   Selector.getterFrom(Selector selector)
       : this(SelectorKind.GETTER, selector.name, selector.library, 0);
@@ skipping 89 matching lines @@
       // TODO(5074): Remove this check once we don't accept the
       // deprecated parameter specification.
       if (!Compiler.REJECT_NAMED_ARGUMENT_AS_POSITIONAL) {
         return optionalParametersAppliesDEPRECATED(element, compiler);
       } else {
         // We have already checked that the number of arguments are
         // not greater than the number of parameters. Therefore the
         // number of positional arguments are not greater than the
         // number of parameters.
         assert(positionalArgumentCount <= parameters.parameterCount);
-        return namedArguments.isEmpty();
+        return namedArguments.isEmpty;
       }
     } else {
       if (positionalArgumentCount > requiredParameterCount) return false;
       assert(positionalArgumentCount == requiredParameterCount);
       if (namedArgumentCount > optionalParameterCount) return false;
       Set<SourceString> nameSet = new Set<SourceString>();
       parameters.optionalParameters.forEach((Element element) {
         nameSet.add(element.name);
       });
       for (SourceString name in namedArguments) {
         if (!nameSet.contains(name)) return false;
         // TODO(5213): By removing from the set we are checking
         // that we are not passing the name twice. We should have this
         // check in the resolver also.
         nameSet.remove(name);
       }
       return true;
     }
   }
 
   // TODO(5074): Remove this method once we don't accept the
   // deprecated parameter specification.
   bool optionalParametersAppliesDEPRECATED(FunctionElement function,
                                            Compiler compiler) {
     FunctionSignature parameters = function.computeSignature(compiler);
     int requiredParameterCount = parameters.requiredParameterCount;
     int optionalParameterCount = parameters.optionalParameterCount;
 
-    bool hasOptionalParameters = !parameters.optionalParameters.isEmpty();
-    if (namedArguments.isEmpty()) {
+    bool hasOptionalParameters = !parameters.optionalParameters.isEmpty;
+    if (namedArguments.isEmpty) {
       if (!hasOptionalParameters) {
         return requiredParameterCount == argumentCount;
       } else {
         return argumentCount >= requiredParameterCount &&
             argumentCount <= requiredParameterCount + optionalParameterCount;
       }
     } else {
       if (!hasOptionalParameters) return false;
       Link<Element> remainingNamedParameters = parameters.optionalParameters;
       for (int i = requiredParameterCount; i < positionalArgumentCount; i++) {
         remainingNamedParameters = remainingNamedParameters.tail;
       }
       Set<SourceString> nameSet = new Set<SourceString>();
       for (;
-           !remainingNamedParameters.isEmpty();
+           !remainingNamedParameters.isEmpty;
            remainingNamedParameters = remainingNamedParameters.tail) {
         nameSet.add(remainingNamedParameters.head.name);
       }
 
       for (SourceString name in namedArguments) {
         if (!nameSet.contains(name)) {
           return false;
         }
         nameSet.remove(name);
       }
@@ skipping 16 matching lines @@
 
     // Visit positional arguments and add them to the list.
     for (int i = parameters.requiredParameterCount;
          i < positionalArgumentCount;
          arguments = arguments.tail, i++) {
       list.add(compileArgument(arguments.head));
     }
 
     // Visit named arguments and add them into a temporary list.
     List compiledNamedArguments = [];
-    for (; !arguments.isEmpty(); arguments = arguments.tail) {
+    for (; !arguments.isEmpty; arguments = arguments.tail) {
       NamedArgument namedArgument = arguments.head;
       compiledNamedArguments.add(compileArgument(namedArgument.expression));
     }
 
     Link<Element> remainingNamedParameters = parameters.optionalParameters;
     // Skip the optional parameters that have been given in the
     // positional arguments.
     for (int i = parameters.requiredParameterCount;
          i < positionalArgumentCount;
          i++) {
       remainingNamedParameters = remainingNamedParameters.tail;
     }
 
     // Loop over the remaining named parameters, and try to find
     // their values: either in the temporary list or using the
     // default value.
     for (;
-         !remainingNamedParameters.isEmpty();
+         !remainingNamedParameters.isEmpty;
          remainingNamedParameters = remainingNamedParameters.tail) {
       Element parameter = remainingNamedParameters.head;
       int foundIndex = namedArguments.indexOf(parameter.name);
       if (foundIndex != -1) {
         list.add(compiledNamedArguments[foundIndex]);
       } else {
         list.add(compileConstant(parameter));
       }
     }
   }
@@ skipping 22 matching lines @@
 
     if (!parameters.optionalParametersAreNamed) {
       // TODO(5074): Remove this check once we don't accept the
       // deprecated parameter specification.
       if (!Compiler.REJECT_NAMED_ARGUMENT_AS_POSITIONAL) {
         addOptionalArgumentsToListDEPRECATED(
             arguments, list, element, compileArgument, compileConstant,
             compiler);
       } else {
         parameters.forEachOptionalParameter((element) {
-          if (!arguments.isEmpty()) {
+          if (!arguments.isEmpty) {
             list.add(compileArgument(arguments.head));
             arguments = arguments.tail;
           } else {
             list.add(compileConstant(element));
           }
         });
       }
     } else {
       // Visit named arguments and add them into a temporary list.
       List compiledNamedArguments = [];
-      for (; !arguments.isEmpty(); arguments = arguments.tail) {
+      for (; !arguments.isEmpty; arguments = arguments.tail) {
         NamedArgument namedArgument = arguments.head;
         compiledNamedArguments.add(compileArgument(namedArgument.expression));
       }
       // Iterate over the optional parameters of the signature, and try to
       // find them in [compiledNamedArguments]. If found, we use the
       // value in the temporary list, otherwise the default value.
       parameters.orderedOptionalParameters.forEach((element) {
         int foundIndex = namedArguments.indexOf(element.name);
         if (foundIndex != -1) {
           list.add(compiledNamedArguments[foundIndex]);
@@ skipping 20 matching lines @@
 
   bool equalsUntyped(Selector other) {
     return name == other.name
            && identical(library, other.library)
            && argumentCount == other.argumentCount
            && namedArguments.length == other.namedArguments.length
            && sameNames(namedArguments, other.namedArguments);
   }
 
   List<SourceString> getOrderedNamedArguments() {
-    if (namedArguments.isEmpty()) return namedArguments;
-    if (!orderedNamedArguments.isEmpty()) return orderedNamedArguments;
+    if (namedArguments.isEmpty) return namedArguments;
+    if (!orderedNamedArguments.isEmpty) return orderedNamedArguments;
 
     orderedNamedArguments.addAll(namedArguments);
     orderedNamedArguments.sort((SourceString first, SourceString second) {
       return first.slowToString().compareTo(second.slowToString());
     });
     return orderedNamedArguments;
   }
 
   String namedArgumentsToString() {
     if (namedArgumentCount > 0) {
@@ skipping 73 matching lines @@
 
     if (!self.isInterface() && self.isSubclassOf(other)) {
       // Resolve an invocation of [element.name] on [self]. If it
       // is found, this selector is a candidate.
       return hasElementIn(self, element) && appliesUntyped(element, compiler);
     }
 
     return false;
   }
 }