Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: lib/compiler/implementation/lib/isolate_patch.dart

Issue 11238035: Make isEmpty a getter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status file with co19 issue number. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/lib/interceptors.dart ('k') | lib/compiler/implementation/lib/js_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/lib/isolate_patch.dart
diff --git a/lib/compiler/implementation/lib/isolate_patch.dart b/lib/compiler/implementation/lib/isolate_patch.dart
index 1aa9ac05ca4703cae5027a9e63e3b44a86931c27..072d35ef80f913289627e46e1f2c76cb1c3622b5 100644
--- a/lib/compiler/implementation/lib/isolate_patch.dart
+++ b/lib/compiler/implementation/lib/isolate_patch.dart
@@ -208,7 +208,7 @@ $globalThis.onmessage = function (e) {
/** Close the worker running this code if all isolates are done. */
void maybeCloseWorker() {
- if (isolates.isEmpty()) {
+ if (isolates.isEmpty) {
mainManager.postMessage(_serializeMessage({'command': 'close'}));
}
}
@@ -269,7 +269,7 @@ class _IsolateContext {
/** Unregister a port on this isolate. */
void unregister(int portId) {
ports.remove(portId);
- if (ports.isEmpty()) {
+ if (ports.isEmpty) {
_globalState.isolates.remove(id); // indicate this isolate is not active
}
}
@@ -286,7 +286,7 @@ class _EventLoop {
}
_IsolateEvent dequeue() {
- if (events.isEmpty()) return null;
+ if (events.isEmpty) return null;
return events.removeFirst();
}
@@ -300,7 +300,7 @@ class _EventLoop {
_globalState.isolates.containsKey(
_globalState.rootContext.id) &&
_globalState.fromCommandLine &&
- _globalState.rootContext.ports.isEmpty()) {
+ _globalState.rootContext.ports.isEmpty) {
// We want to reach here only on the main [_Manager] and only
// on the command-line. In the browser the isolate might
// still be alive due to DOM callbacks, but the presumption is
« no previous file with comments | « lib/compiler/implementation/lib/interceptors.dart ('k') | lib/compiler/implementation/lib/js_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698