Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: lib/compiler/implementation/compile_time_constants.dart

Issue 11238035: Make isEmpty a getter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status file with co19 issue number. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/code_buffer.dart ('k') | lib/compiler/implementation/dart2js.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/compile_time_constants.dart
diff --git a/lib/compiler/implementation/compile_time_constants.dart b/lib/compiler/implementation/compile_time_constants.dart
index aa6a7a58d9dc8e55d522474a0fe81ba3e9be9162..0a3eea61b699664af32b3b96c767e1fd55027594 100644
--- a/lib/compiler/implementation/compile_time_constants.dart
+++ b/lib/compiler/implementation/compile_time_constants.dart
@@ -58,7 +58,7 @@ class ConstantHandler extends CompilerTask {
if (result != null) return result;
if (lazyStatics.contains(element)) return null;
result = compileVariableWithDefinitions(element, work.resolutionTree);
- assert(pendingVariables.isEmpty());
+ assert(pendingVariables.isEmpty);
return result;
});
}
@@ -286,7 +286,7 @@ class CompileTimeConstantEvaluator extends Visitor {
}
List<Constant> arguments = <Constant>[];
for (Link<Node> link = node.elements.nodes;
- !link.isEmpty();
+ !link.isEmpty;
link = link.tail) {
arguments.add(evaluateConstant(link.head));
}
@@ -305,7 +305,7 @@ class CompileTimeConstantEvaluator extends Visitor {
List<StringConstant> keys = <StringConstant>[];
Map<StringConstant, Constant> map = new Map<StringConstant, Constant>();
for (Link<Node> link = node.entries.nodes;
- !link.isEmpty();
+ !link.isEmpty;
link = link.tail) {
LiteralMapEntry entry = link.head;
Constant key = evaluateConstant(entry.key);
@@ -737,7 +737,7 @@ class ConstructorEvaluator extends CompileTimeConstantEvaluator {
if (initializerList != null) {
for (Link<Node> link = initializerList.nodes;
- !link.isEmpty();
+ !link.isEmpty;
link = link.tail) {
assert(link.head is Send);
if (link.head is !SendSet) {
@@ -753,7 +753,7 @@ class ConstructorEvaluator extends CompileTimeConstantEvaluator {
// A field initializer.
SendSet init = link.head;
Link<Node> initArguments = init.arguments;
- assert(!initArguments.isEmpty() && initArguments.tail.isEmpty());
+ assert(!initArguments.isEmpty && initArguments.tail.isEmpty);
Constant fieldValue = evaluate(initArguments.head);
updateFieldValue(init, elements[init], fieldValue);
}
« no previous file with comments | « lib/compiler/implementation/code_buffer.dart ('k') | lib/compiler/implementation/dart2js.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698