Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: lib/compiler/implementation/ssa/codegen_helpers.dart

Issue 11238035: Make isEmpty a getter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status file with co19 issue number. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/codegen.dart ('k') | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/codegen_helpers.dart
diff --git a/lib/compiler/implementation/ssa/codegen_helpers.dart b/lib/compiler/implementation/ssa/codegen_helpers.dart
index 611dcf122bbda6bed44ba68e50b26246edb4adf5..7f707c9e6479ca7dfbaa7ff6fcac1c77f9e2514b 100644
--- a/lib/compiler/implementation/ssa/codegen_helpers.dart
+++ b/lib/compiler/implementation/ssa/codegen_helpers.dart
@@ -132,7 +132,7 @@ class SsaInstructionMerger extends HBaseVisitor {
// Pop instructions from expectedInputs until instruction is found.
// Return true if it is found, or false if not.
bool findInInputsAndPopNonMatching(HInstruction instruction) {
- while (!expectedInputs.isEmpty()) {
+ while (!expectedInputs.isEmpty) {
HInstruction nextInput = expectedInputs.removeLast();
assert(!generateAtUseSite.contains(nextInput));
assert(nextInput.usedBy.length == 1);
@@ -162,14 +162,14 @@ class SsaInstructionMerger extends HBaseVisitor {
if (findInInputsAndPopNonMatching(instruction)) {
tryGenerateAtUseSite(instruction);
} else {
- assert(expectedInputs.isEmpty());
+ assert(expectedInputs.isEmpty);
}
instruction.accept(this);
}
if (block.predecessors.length == 1
&& isBlockSinglePredecessor(block.predecessors[0])) {
- assert(block.phis.isEmpty());
+ assert(block.phis.isEmpty);
tryMergingExpressions(block.predecessors[0]);
} else {
expectedInputs = null;
@@ -276,7 +276,7 @@ class SsaConditionMerger extends HGraphVisitor {
// phi(phi1, true|false)
if (end == null) return;
- if (end.phis.isEmpty()) return;
+ if (end.phis.isEmpty) return;
if (!identical(end.phis.first, end.phis.last)) return;
HBasicBlock elseBlock = startIf.elseBlock;
@@ -308,7 +308,7 @@ class SsaConditionMerger extends HGraphVisitor {
if (otherJoin.first != otherJoin.last) return;
if (otherJoin.successors.length != 1) return;
if (otherJoin.successors[0] != end) return;
- if (otherJoin.phis.isEmpty()) return;
+ if (otherJoin.phis.isEmpty) return;
if (!identical(otherJoin.phis.first, otherJoin.phis.last)) return;
HPhi otherPhi = otherJoin.phis.first;
if (thenInput != otherPhi) return;
« no previous file with comments | « lib/compiler/implementation/ssa/codegen.dart ('k') | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698