Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: lib/compiler/implementation/elements/elements.dart

Issue 11238035: Make isEmpty a getter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status file with co19 issue number. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/dart_backend/utils.dart ('k') | lib/compiler/implementation/enqueue.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/elements/elements.dart
diff --git a/lib/compiler/implementation/elements/elements.dart b/lib/compiler/implementation/elements/elements.dart
index dd153ab8905527ba3835b9a6ddf7db558708a8b9..86e6bbd224652a21a863d09e495ee43afaa29423 100644
--- a/lib/compiler/implementation/elements/elements.dart
+++ b/lib/compiler/implementation/elements/elements.dart
@@ -540,7 +540,7 @@ class CompilationUnitElement extends ContainerElement {
api_e.Diagnostic.WARNING);
return;
}
- if (!localMembers.isEmpty()) {
+ if (!localMembers.isEmpty) {
listener.reportMessage(
listener.spanFromNode(tag),
MessageKind.BEFORE_TOP_LEVEL.error(),
@@ -841,7 +841,7 @@ class VariableElement extends Element {
if (cachedNode != null) return cachedNode;
VariableDefinitions definitions = variables.parseNode(listener);
for (Link<Node> link = definitions.definitions.nodes;
- !link.isEmpty(); link = link.tail) {
+ !link.isEmpty; link = link.tail) {
Expression initializedIdentifier = link.head;
Identifier identifier = initializedIdentifier.asIdentifier();
if (identifier == null) {
@@ -925,9 +925,9 @@ class VariableListElement extends Element {
} else {
// Is node.definitions exactly one FunctionExpression?
Link<Node> link = node.definitions.nodes;
- if (!link.isEmpty() &&
+ if (!link.isEmpty &&
link.head.asFunctionExpression() != null &&
- link.tail.isEmpty()) {
+ link.tail.isEmpty) {
FunctionExpression functionExpression = link.head;
// We found exactly one FunctionExpression
functionSignature =
@@ -1031,7 +1031,7 @@ class FunctionSignature {
void forEachRequiredParameter(void function(Element parameter)) {
for (Link<Element> link = requiredParameters;
- !link.isEmpty();
+ !link.isEmpty;
link = link.tail) {
function(link.head);
}
@@ -1039,7 +1039,7 @@ class FunctionSignature {
void forEachOptionalParameter(void function(Element parameter)) {
for (Link<Element> link = optionalParameters;
- !link.isEmpty();
+ !link.isEmpty;
link = link.tail) {
function(link.head);
}
@@ -1270,7 +1270,7 @@ abstract class TypeDeclarationElement implements Element {
// Create types and elements for type variable.
var arguments = new LinkBuilder<DartType>();
- for (Link link = parameters.nodes; !link.isEmpty(); link = link.tail) {
+ for (Link link = parameters.nodes; !link.isEmpty; link = link.tail) {
TypeVariable node = link.head;
SourceString variableName = node.name.source;
TypeVariableElement variableElement =
« no previous file with comments | « lib/compiler/implementation/dart_backend/utils.dart ('k') | lib/compiler/implementation/enqueue.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698