Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: pkg/dartdoc/lib/src/client/dropdown.dart

Issue 11238035: Make isEmpty a getter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status file with co19 issue number. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dartdoc/lib/mirrors_util.dart ('k') | pkg/dartdoc/lib/src/client/search.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dartdoc/lib/src/client/dropdown.dart
diff --git a/pkg/dartdoc/lib/src/client/dropdown.dart b/pkg/dartdoc/lib/src/client/dropdown.dart
index 8da62bcbdc4a3b2af2dd6e51a02be36689a9db26..30d63fe0482c5dd10f5bdf5c51f47cc5823cb9fe 100644
--- a/pkg/dartdoc/lib/src/client/dropdown.dart
+++ b/pkg/dartdoc/lib/src/client/dropdown.dart
@@ -19,7 +19,7 @@ updateDropDown(Event event) {
if (text == currentSearchText) {
return;
}
- if (text.isEmpty()) {
+ if (text.isEmpty) {
updateResults(text, results);
hideDropDown();
return;
@@ -29,12 +29,12 @@ updateDropDown(Event event) {
String typeText = text.substring(0, text.indexOf('.'));
String memberText = text.substring(text.indexOf('.') + 1);
- if (typeText.isEmpty() && memberText.isEmpty()) {
+ if (typeText.isEmpty && memberText.isEmpty) {
// Don't search on '.'.
- } else if (typeText.isEmpty()) {
+ } else if (typeText.isEmpty) {
// Search text is of the form '.id' => Look up members.
matchAllMembers(results, memberText);
- } else if (memberText.isEmpty()) {
+ } else if (memberText.isEmpty) {
// Search text is of the form 'Type.' => Look up members in 'Type'.
matchAllMembersInType(results, typeText, memberText);
} else {
@@ -55,7 +55,7 @@ updateDropDown(Event event) {
table.classes.add('drop-down-table');
elements.add(table);
- if (results.isEmpty()) {
+ if (results.isEmpty) {
var row = table.insertRow(0);
row.innerHTML = "<tr><td>No matches found for '$text'.</td></tr>";
} else {
@@ -239,7 +239,7 @@ List<Result> currentResults = const <Result>[];
void updateResults(String searchText, List<Result> results) {
currentSearchText = searchText;
currentResults = results;
- if (currentResults.isEmpty()) {
+ if (currentResults.isEmpty) {
_currentResultIndex = -1;
currentResult = null;
} else {
@@ -305,7 +305,7 @@ void handleUpDown(KeyboardEvent event) {
/** Show the search drop down unless there are no current results. */
void showDropDown() {
- if (currentResults.isEmpty()) {
+ if (currentResults.isEmpty) {
hideDropDown();
} else {
dropdown.style.visibility = 'visible';
« no previous file with comments | « pkg/dartdoc/lib/mirrors_util.dart ('k') | pkg/dartdoc/lib/src/client/search.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698