Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: runtime/bin/path_impl.dart

Issue 11238035: Make isEmpty a getter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status file with co19 issue number. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/list_stream_impl.dart ('k') | runtime/bin/socket.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/path_impl.dart
diff --git a/runtime/bin/path_impl.dart b/runtime/bin/path_impl.dart
index 91d1ed332afd6ed55a2c5e16a1ba82c7f5f9bdd2..2d04e9e83e1ed514e656d408bc1be899b14e8c38 100644
--- a/runtime/bin/path_impl.dart
+++ b/runtime/bin/path_impl.dart
@@ -29,7 +29,7 @@ class _Path implements Path {
return clean;
}
- bool get isEmpty => _path.isEmpty();
+ bool get isEmpty => _path.isEmpty;
bool get isAbsolute => _path.startsWith('/');
bool get hasTrailingSeparator => _path.endsWith('/');
@@ -129,7 +129,7 @@ class _Path implements Path {
List segs = segments();
String drive;
if (isAbs &&
- !segs.isEmpty() &&
+ !segs.isEmpty &&
segs[0].length == 2 &&
segs[0][1] == ':') {
drive = segs[0];
@@ -140,7 +140,7 @@ class _Path implements Path {
switch (segment) {
case '..':
// Absolute paths drop leading .. markers, including after a drive.
- if (newSegs.isEmpty()) {
+ if (newSegs.isEmpty) {
if (isAbs) {
// Do nothing: drop the segment.
} else {
@@ -170,7 +170,7 @@ class _Path implements Path {
}
}
- if (newSegs.isEmpty()) {
+ if (newSegs.isEmpty) {
if (isAbs) {
segmentsToJoin.add('');
} else {
« no previous file with comments | « runtime/bin/list_stream_impl.dart ('k') | runtime/bin/socket.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698