Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3522004: FBTF: Move ctors/dtors into implementation files. Adds ctors/dtors to non-POD structs. (Closed)

Created:
10 years, 2 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, michaeln, cbentzel+watch_chromium.org, ben+cc_chromium.org, brettw-cc_chromium.org, jam, darin-cc_chromium.org, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

FBTF: Move ctors/dtors into implementation files. Adds ctors/dtors to non-POD structs. Cuts ~2MB off our .a files (Debug, Linux). Also added the "virtual" keyword on a whole bunch of virtual dtors that were missing it. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61100

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+542 lines, -186 lines) Patch
M base/simple_thread.h View 3 chunks +7 lines, -15 lines 0 comments Download
M base/simple_thread.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M chrome/browser/history/history_types.h View 5 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/history/history_types.cc View 2 chunks +37 lines, -0 lines 0 comments Download
M chrome/browser/history/snippet.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/history/snippet.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/importer/importer_bridge.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/importer/importer_bridge.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/importer/importer_data_types.h View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/importer/importer_data_types.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/importer/profile_writer.h View 3 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/importer/profile_writer.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/profile_import_process_host.h View 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/profile_import_process_host.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/net/gaia/gaia_authenticator.h View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/common/net/gaia/gaia_authenticator.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/common/net/url_fetcher_protect.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/net/url_fetcher_protect.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/net/url_request_context_getter.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/common/net/url_request_context_getter.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/web_resource/web_resource_unpacker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/web_resource/web_resource_unpacker.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M gfx/gtk_native_view_id_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M gfx/gtk_native_view_id_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M gfx/platform_font_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M gfx/platform_font_gtk.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ipc/ipc_channel_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ipc/ipc_message_utils.h View 2 chunks +5 lines, -24 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M net/base/ssl_client_auth_cache.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/ssl_client_auth_cache.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/disk_cache/in_flight_backend_io.h View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/in_flight_backend_io.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/ftp/ftp_auth_cache.h View 1 chunk +4 lines, -7 lines 0 comments Download
M net/ftp/ftp_auth_cache.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M net/http/http_auth_cache.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/http/http_auth_cache.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M net/proxy/proxy_config_service_common_unittest.h View 1 chunk +1 line, -11 lines 0 comments Download
M net/proxy/proxy_config_service_common_unittest.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M net/proxy/proxy_list.h View 1 chunk +5 lines, -1 line 0 comments Download
M net/proxy/proxy_list.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M net/proxy/proxy_list_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/proxy/proxy_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_service.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/socket/client_socket_pool.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/socket/client_socket_pool.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/socket/client_socket_pool_histograms.h View 2 chunks +4 lines, -2 lines 1 comment Download
M net/socket/client_socket_pool_histograms.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/socket/socket_test_util.h View 1 chunk +2 lines, -6 lines 0 comments Download
M net/socket/socket_test_util.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/tcp_client_socket_pool.cc View 1 chunk +1 line, -0 lines 0 comments Download
M printing/print_settings.h View 1 chunk +1 line, -0 lines 0 comments Download
M printing/print_settings.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M printing/printed_document.h View 3 chunks +3 lines, -1 line 0 comments Download
M printing/printed_document.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M skia/ext/SkFontHost_fontconfig_direct.h View 1 chunk +16 lines, -15 lines 0 comments Download
M skia/ext/SkFontHost_fontconfig_direct.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/appcache/appcache_backend_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_backend_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M webkit/appcache/appcache_interfaces.h View 2 chunks +7 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_interfaces.cc View 2 chunks +24 lines, -1 line 0 comments Download
M webkit/appcache/appcache_response.h View 2 chunks +4 lines, -7 lines 0 comments Download
M webkit/appcache/appcache_response.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M webkit/appcache/appcache_service.h View 1 chunk +3 lines, -1 line 0 comments Download
M webkit/appcache/appcache_service.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/appcache/appcache_storage.h View 3 chunks +3 lines, -9 lines 0 comments Download
M webkit/appcache/appcache_storage.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M webkit/appcache/appcache_update_job.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/appcache/appcache_update_job.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M webkit/appcache/appcache_working_set.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_working_set.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/appcache/manifest_parser.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/appcache/manifest_parser.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_url_request_info.h View 1 chunk +1 line, -25 lines 0 comments Download
M webkit/glue/plugins/pepper_url_request_info.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M webkit/glue/plugins/plugin_list.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/glue/plugins/plugin_list.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/glue/plugins/webplugin_impl.h View 2 chunks +1 line, -8 lines 0 comments Download
M webkit/glue/plugins/webplugin_impl.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
10 years, 2 months ago (2010-09-30 01:08:21 UTC) #1
Lei Zhang
10 years, 2 months ago (2010-09-30 01:15:17 UTC) #2 
LGTM

http://codereview.chromium.org/3522004/diff/1/51
File net/socket/client_socket_pool_histograms.h (right):

http://codereview.chromium.org/3522004/diff/1/51#newcode11
net/socket/client_socket_pool_histograms.h:11: #include "base/time.h"
nit: sort alphabetically.

Powered by Google App Engine
This is Rietveld 408576698