Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: printing/printed_document.h

Issue 3522004: FBTF: Move ctors/dtors into implementation files. Adds ctors/dtors to non-POD structs. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: printing/printed_document.h
diff --git a/printing/printed_document.h b/printing/printed_document.h
index e4a32806135194e5f9abf22a873d35aa381cef8e..dfab7a560bd7f1ba1197fda65d1390edf1027fbe 100644
--- a/printing/printed_document.h
+++ b/printing/printed_document.h
@@ -111,7 +111,7 @@ class PrintedDocument : public base::RefCountedThreadSafe<PrintedDocument> {
private:
friend class base::RefCountedThreadSafe<PrintedDocument>;
- ~PrintedDocument();
+ virtual ~PrintedDocument();
// Array of data for each print previewed page.
typedef std::map<int, scoped_refptr<PrintedPage> > PrintedPages;
@@ -120,6 +120,7 @@ class PrintedDocument : public base::RefCountedThreadSafe<PrintedDocument> {
// lock held.
struct Mutable {
explicit Mutable(PrintedPagesSource* source);
+ ~Mutable();
// Source that generates the PrintedPage's (i.e. a TabContents). It will be
// set back to NULL if the source is deleted before this object.
@@ -146,6 +147,7 @@ class PrintedDocument : public base::RefCountedThreadSafe<PrintedDocument> {
struct Immutable {
Immutable(const PrintSettings& settings, PrintedPagesSource* source,
int cookie);
+ ~Immutable();
// Print settings used to generate this document. Immutable.
PrintSettings settings_;

Powered by Google App Engine
This is Rietveld 408576698