Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: chrome/common/net/gaia/gaia_authenticator.cc

Issue 3522004: FBTF: Move ctors/dtors into implementation files. Adds ctors/dtors to non-POD structs. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/net/gaia/gaia_authenticator.h" 5 #include "chrome/common/net/gaia/gaia_authenticator.h"
6 6
7 #include <string> 7 #include <string>
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/basictypes.h" 11 #include "base/basictypes.h"
12 #include "base/port.h" 12 #include "base/port.h"
13 #include "base/string_split.h" 13 #include "base/string_split.h"
14 #include "chrome/common/deprecated/event_sys-inl.h" 14 #include "chrome/common/deprecated/event_sys-inl.h"
15 #include "chrome/common/net/http_return.h" 15 #include "chrome/common/net/http_return.h"
16 #include "googleurl/src/gurl.h" 16 #include "googleurl/src/gurl.h"
17 #include "net/base/escape.h" 17 #include "net/base/escape.h"
18 18
19 using std::pair; 19 using std::pair;
20 using std::string; 20 using std::string;
21 using std::vector; 21 using std::vector;
22 22
23 namespace gaia { 23 namespace gaia {
24 24
25 static const char kGaiaV1IssueAuthTokenPath[] = "/accounts/IssueAuthToken"; 25 static const char kGaiaV1IssueAuthTokenPath[] = "/accounts/IssueAuthToken";
26 26
27 static const char kGetUserInfoPath[] = "/accounts/GetUserInfo"; 27 static const char kGetUserInfoPath[] = "/accounts/GetUserInfo";
28 28
29 GaiaAuthenticator::AuthResults::AuthResults() : auth_error(None) {}
30
31 GaiaAuthenticator::AuthResults::~AuthResults() {}
32
33 GaiaAuthenticator::AuthParams::AuthParams() {}
34
35 GaiaAuthenticator::AuthParams::~AuthParams() {}
36
29 // Sole constructor with initializers for all fields. 37 // Sole constructor with initializers for all fields.
30 GaiaAuthenticator::GaiaAuthenticator(const string& user_agent, 38 GaiaAuthenticator::GaiaAuthenticator(const string& user_agent,
31 const string& service_id, 39 const string& service_id,
32 const string& gaia_url) 40 const string& gaia_url)
33 : user_agent_(user_agent), 41 : user_agent_(user_agent),
34 service_id_(service_id), 42 service_id_(service_id),
35 gaia_url_(gaia_url), 43 gaia_url_(gaia_url),
36 request_count_(0), 44 request_count_(0),
37 delay_(0), 45 delay_(0),
38 next_allowed_auth_attempt_time_(0), 46 next_allowed_auth_attempt_time_(0),
(...skipping 328 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 bool GaiaAuthenticator::Authenticate(const string& user_name, 375 bool GaiaAuthenticator::Authenticate(const string& user_name,
368 const string& password) { 376 const string& password) {
369 DCHECK_EQ(MessageLoop::current(), message_loop_); 377 DCHECK_EQ(MessageLoop::current(), message_loop_);
370 const string empty; 378 const string empty;
371 return Authenticate(user_name, password, empty, 379 return Authenticate(user_name, password, empty,
372 empty); 380 empty);
373 } 381 }
374 382
375 } // namepace gaia 383 } // namepace gaia
376 384
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698