net/socket/client_socket_pool_histograms.h - Issue 3522004: FBTF: Move ctors/dtors into implementation files. Adds ctors/dtors to non-POD structs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/client_socket_pool_histograms.h

Issue 3522004: FBTF: Move ctors/dtors into implementation files. Adds ctors/dtors to non-POD structs. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/client_socket_pool_histograms.h

diff --git a/net/socket/client_socket_pool_histograms.h b/net/socket/client_socket_pool_histograms.h

index 7485c2f00b8fb9f1d513440362dc0b6152e987cb..0408cc002591577b8ee29e4caeb424a3c82644ba 100644

--- a/net/socket/client_socket_pool_histograms.h

+++ b/net/socket/client_socket_pool_histograms.h

@@ -8,9 +8,11 @@

#include <string>

-#include "base/histogram.h"

+#include "base/time.h"

Lei Zhang 2010/09/30 01:15:18 nit: sort alphabetically.

#include "base/ref_counted.h"

+class Histogram;

namespace net {

class ClientSocketPoolHistograms

@@ -25,7 +27,7 @@ class ClientSocketPoolHistograms

private:

friend class base::RefCounted<ClientSocketPoolHistograms>;

- ~ClientSocketPoolHistograms() {}

+ virtual ~ClientSocketPoolHistograms();

scoped_refptr<Histogram> socket_type_;

scoped_refptr<Histogram> request_time_;

« no previous file with comments | « net/socket/client_socket_pool.cc ('k') | net/socket/client_socket_pool_histograms.cc » ('j') | no next file with comments »