Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: webkit/appcache/appcache_response.h

Issue 3522004: FBTF: Move ctors/dtors into implementation files. Adds ctors/dtors to non-POD structs. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/appcache/appcache_response.h
diff --git a/webkit/appcache/appcache_response.h b/webkit/appcache/appcache_response.h
index 1f8ecce9d9fa6246d78356ec489e5c02f2e4ea3a..5f62b14084ec16810368dd771bb9c30b1d3a742b 100644
--- a/webkit/appcache/appcache_response.h
+++ b/webkit/appcache/appcache_response.h
@@ -48,7 +48,7 @@ class AppCacheResponseInfo
private:
friend class base::RefCounted<AppCacheResponseInfo>;
- ~AppCacheResponseInfo();
+ virtual ~AppCacheResponseInfo();
const GURL manifest_url_;
const int64 response_id_;
@@ -64,15 +64,12 @@ struct HttpResponseInfoIOBuffer
scoped_ptr<net::HttpResponseInfo> http_info;
int response_data_size;
- HttpResponseInfoIOBuffer()
- : response_data_size(kUnkownResponseDataSize) {}
- explicit HttpResponseInfoIOBuffer(net::HttpResponseInfo* info)
- : http_info(info), response_data_size(kUnkownResponseDataSize) {}
+ HttpResponseInfoIOBuffer();
+ explicit HttpResponseInfoIOBuffer(net::HttpResponseInfo* info);
private:
friend class base::RefCountedThreadSafe<HttpResponseInfoIOBuffer>;
-
- ~HttpResponseInfoIOBuffer() {}
+ virtual ~HttpResponseInfoIOBuffer();
};
// Common base class for response reader and writer.

Powered by Google App Engine
This is Rietveld 408576698