Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2726)

Unified Diff: chrome/browser/history/snippet.h

Issue 3522004: FBTF: Move ctors/dtors into implementation files. Adds ctors/dtors to non-POD structs. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/snippet.h
diff --git a/chrome/browser/history/snippet.h b/chrome/browser/history/snippet.h
index ffa8fa19f7b80bea8305dfedd6257305fc7952a6..bbabef028f4344442afa8a7cc6bd65884f65bcf6 100644
--- a/chrome/browser/history/snippet.h
+++ b/chrome/browser/history/snippet.h
@@ -43,6 +43,9 @@ class Snippet {
const std::string& utf8_string,
Snippet::MatchPositions* match_positions);
+ Snippet();
+ ~Snippet();
+
// Given |matches|, the match positions within |document|, compute the snippet
// for the document.
// Note that |document| is UTF-8 and the offsets in |matches| are byte
@@ -54,10 +57,7 @@ class Snippet {
const MatchPositions& matches() const { return matches_; }
// Efficiently swaps the contents of this snippet with the other.
- void Swap(Snippet* other) {
- text_.swap(other->text_);
- matches_.swap(other->matches_);
- }
+ void Swap(Snippet* other);
private:
// The text of the snippet.

Powered by Google App Engine
This is Rietveld 408576698