Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6967)

Unified Diff: chrome/common/net/gaia/gaia_authenticator.h

Issue 3522004: FBTF: Move ctors/dtors into implementation files. Adds ctors/dtors to non-POD structs. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/net/gaia/gaia_authenticator.h
diff --git a/chrome/common/net/gaia/gaia_authenticator.h b/chrome/common/net/gaia/gaia_authenticator.h
index 696f40346e6cd5562fef6827f7b7c700abf9140e..789863e9c8d9007272ab71d2ddf2c3eb01be88e6 100644
--- a/chrome/common/net/gaia/gaia_authenticator.h
+++ b/chrome/common/net/gaia/gaia_authenticator.h
@@ -131,6 +131,9 @@ class GaiaAuthenticator {
void SetAuthToken(const std::string& auth_token);
struct AuthResults {
+ AuthResults();
+ ~AuthResults();
+
std::string email;
std::string password;
@@ -147,13 +150,14 @@ class GaiaAuthenticator {
std::string auth_error_url;
std::string captcha_token;
std::string captcha_url;
-
- AuthResults() : auth_error(None) {}
};
protected:
struct AuthParams {
+ AuthParams();
+ ~AuthParams();
+
GaiaAuthenticator* authenticator;
uint32 request_id;
std::string email;

Powered by Google App Engine
This is Rietveld 408576698