FBTF: Move ctors/dtors into implementation files. Adds ctors/dtors to non-POD structs.

chrome/browser/importer/profile_writer.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_IMPORTER_PROFILE_WRITER_H_
 #define CHROME_BROWSER_IMPORTER_PROFILE_WRITER_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 30 matching lines @@
     // URL with the same url, path and title.
     ADD_IF_UNIQUE = 1 << 0,
 
     // Indicates the bookmarks should be added to the bookmark bar.
     IMPORT_TO_BOOKMARK_BAR = 1 << 1,
 
     // Indicates the bookmark bar is not shown.
     BOOKMARK_BAR_DISABLED = 1 << 2
   };
 
-  explicit ProfileWriter(Profile* profile) : profile_(profile) {}
-
-  // These functions return true if the corresponding model has been loaded.
-  // If the models haven't been loaded, the importer waits to run until they've
-  // completed.
-  virtual bool BookmarkModelIsLoaded() const;
-  virtual bool TemplateURLModelIsLoaded() const;
-
   // A bookmark entry.
   // TODO(mirandac): remove instances of wstring from ProfileWriter
   // (http://crbug.com/43460).
   struct BookmarkEntry {
-    BookmarkEntry() : in_toolbar(false) {}
+    BookmarkEntry();
+    ~BookmarkEntry();
+
     bool in_toolbar;
     GURL url;
     std::vector<std::wstring> path;
     std::wstring title;
     base::Time creation_time;
   };
 
+  explicit ProfileWriter(Profile* profile);
+
+  // These functions return true if the corresponding model has been loaded.
+  // If the models haven't been loaded, the importer waits to run until they've
+  // completed.
+  virtual bool BookmarkModelIsLoaded() const;
+  virtual bool TemplateURLModelIsLoaded() const;
+
   // Helper methods for adding data to local stores.
   virtual void AddPasswordForm(const webkit_glue::PasswordForm& form);
 #if defined(OS_WIN)
   virtual void AddIE7PasswordInfo(const IE7PasswordInfo& info);
 #endif
   virtual void AddHistoryPage(const std::vector<history::URLRow>& page,
                               history::VisitSource visit_source);
   virtual void AddHomepage(const GURL& homepage);
   // Adds the bookmarks to the BookmarkModel.
   // |options| is a bitmask of BookmarkOptions and dictates how and
@@ skipping 27 matching lines @@
                            bool unique_on_host_and_path);
 
   // Shows the bookmarks toolbar.
   void ShowBookmarkBar();
 
   Profile* profile() const { return profile_; }
 
  protected:
   friend class base::RefCountedThreadSafe<ProfileWriter>;
 
-  virtual ~ProfileWriter() {}
+  virtual ~ProfileWriter();
 
  private:
   // Generates a unique folder name. If folder_name is not unique, then this
   // repeatedly tests for '|folder_name| + (i)' until a unique name is found.
   std::wstring GenerateUniqueFolderName(BookmarkModel* model,
                                         const std::wstring& folder_name);
 
   // Returns true if a bookmark exists with the same url, title and path
   // as |entry|. |first_folder_name| is the name to use for the first
   // path entry if |import_to_bookmark_bar| is true.
   bool DoesBookmarkExist(BookmarkModel* model,
                          const BookmarkEntry& entry,
                          const std::wstring& first_folder_name,
                          bool import_to_bookmark_bar);
 
   Profile* const profile_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileWriter);
 };
 
 #endif  // CHROME_BROWSER_IMPORTER_PROFILE_WRITER_H_