Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: webkit/glue/plugins/webplugin_impl.h

Issue 3522004: FBTF: Move ctors/dtors into implementation files. Adds ctors/dtors to non-POD structs. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_GLUE_WEBPLUGIN_IMPL_H_ 5 #ifndef WEBKIT_GLUE_WEBPLUGIN_IMPL_H_
6 #define WEBKIT_GLUE_WEBPLUGIN_IMPL_H_ 6 #define WEBKIT_GLUE_WEBPLUGIN_IMPL_H_
7 7
8 #include <string> 8 #include <string>
9 #include <map> 9 #include <map>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/basictypes.h" 12 #include "base/basictypes.h"
13 #include "base/file_path.h" 13 #include "base/file_path.h"
14 #include "base/linked_ptr.h"
15 #include "base/task.h" 14 #include "base/task.h"
16 #include "base/weak_ptr.h" 15 #include "base/weak_ptr.h"
17 #include "gfx/native_widget_types.h" 16 #include "gfx/native_widget_types.h"
18 #include "googleurl/src/gurl.h" 17 #include "googleurl/src/gurl.h"
19 #include "third_party/WebKit/WebKit/chromium/public/WebPlugin.h" 18 #include "third_party/WebKit/WebKit/chromium/public/WebPlugin.h"
20 #include "third_party/WebKit/WebKit/chromium/public/WebRect.h" 19 #include "third_party/WebKit/WebKit/chromium/public/WebRect.h"
21 #include "third_party/WebKit/WebKit/chromium/public/WebString.h" 20 #include "third_party/WebKit/WebKit/chromium/public/WebString.h"
22 #include "third_party/WebKit/WebKit/chromium/public/WebURLLoaderClient.h" 21 #include "third_party/WebKit/WebKit/chromium/public/WebURLLoaderClient.h"
23 #include "third_party/WebKit/WebKit/chromium/public/WebURLRequest.h" 22 #include "third_party/WebKit/WebKit/chromium/public/WebURLRequest.h"
24 #include "third_party/WebKit/WebKit/chromium/public/WebVector.h" 23 #include "third_party/WebKit/WebKit/chromium/public/WebVector.h"
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 bool popups_allowed, 248 bool popups_allowed,
250 Referrer referrer_flag); 249 Referrer referrer_flag);
251 250
252 // Tears down the existing plugin instance and creates a new plugin instance 251 // Tears down the existing plugin instance and creates a new plugin instance
253 // to handle the response identified by the loader parameter. 252 // to handle the response identified by the loader parameter.
254 bool ReinitializePluginForResponse(WebKit::WebURLLoader* loader); 253 bool ReinitializePluginForResponse(WebKit::WebURLLoader* loader);
255 254
256 // Delayed task for downloading the plugin source URL. 255 // Delayed task for downloading the plugin source URL.
257 void OnDownloadPluginSrcUrl(); 256 void OnDownloadPluginSrcUrl();
258 257
259 struct ClientInfo { 258 struct ClientInfo;
260 unsigned long id;
261 WebPluginResourceClient* client;
262 WebKit::WebURLRequest request;
263 bool pending_failure_notification;
264 linked_ptr<WebKit::WebURLLoader> loader;
265 };
266 259
267 // Helper functions 260 // Helper functions
268 WebPluginResourceClient* GetClientFromLoader(WebKit::WebURLLoader* loader); 261 WebPluginResourceClient* GetClientFromLoader(WebKit::WebURLLoader* loader);
269 ClientInfo* GetClientInfoFromLoader(WebKit::WebURLLoader* loader); 262 ClientInfo* GetClientInfoFromLoader(WebKit::WebURLLoader* loader);
270 263
271 // Helper function to set the referrer on the request passed in. 264 // Helper function to set the referrer on the request passed in.
272 void SetReferrer(WebKit::WebURLRequest* request, Referrer referrer_flag); 265 void SetReferrer(WebKit::WebURLRequest* request, Referrer referrer_flag);
273 266
274 // Returns DevToolsAgent for the frame or 0. 267 // Returns DevToolsAgent for the frame or 0.
275 WebKit::WebDevToolsAgent* GetDevToolsAgent(); 268 WebKit::WebDevToolsAgent* GetDevToolsAgent();
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 std::vector<std::string> arg_values_; 317 std::vector<std::string> arg_values_;
325 318
326 ScopedRunnableMethodFactory<WebPluginImpl> method_factory_; 319 ScopedRunnableMethodFactory<WebPluginImpl> method_factory_;
327 320
328 DISALLOW_COPY_AND_ASSIGN(WebPluginImpl); 321 DISALLOW_COPY_AND_ASSIGN(WebPluginImpl);
329 }; 322 };
330 323
331 } // namespace webkit_glue 324 } // namespace webkit_glue
332 325
333 #endif // #ifndef WEBKIT_GLUE_WEBPLUGIN_IMPL_H_ 326 #endif // #ifndef WEBKIT_GLUE_WEBPLUGIN_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698