Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chrome/browser/history/history_types.h

Issue 3522004: FBTF: Move ctors/dtors into implementation files. Adds ctors/dtors to non-POD structs. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_types.h
diff --git a/chrome/browser/history/history_types.h b/chrome/browser/history/history_types.h
index 8fab6027987b5c4af434592640f0d9b4ded7853a..b479cbcc4fbceb3855d6c62185a18f75ec6c7f05 100644
--- a/chrome/browser/history/history_types.h
+++ b/chrome/browser/history/history_types.h
@@ -242,6 +242,9 @@ typedef std::vector<VisitRow> VisitVector;
// Used by the importer to set favicons for imported bookmarks.
struct ImportedFavIconUsage {
+ ImportedFavIconUsage();
+ ~ImportedFavIconUsage();
+
// The URL of the favicon.
GURL favicon_url;
@@ -479,7 +482,7 @@ class QueryResults {
// QueryOptions ----------------------------------------------------------------
struct QueryOptions {
- QueryOptions() : max_count(0) {}
+ QueryOptions();
// The time range to search for matches in.
//
@@ -497,10 +500,7 @@ struct QueryOptions {
base::Time end_time;
// Sets the query time to the last |days_ago| days to the present time.
- void SetRecentDayRange(int days_ago) {
- end_time = base::Time::Now();
- begin_time = end_time - base::TimeDelta::FromDays(days_ago);
- }
+ void SetRecentDayRange(int days_ago);
// The maximum number of results to return. The results will be sorted with
// the most recent first, so older results may not be returned if there is not
@@ -513,6 +513,9 @@ struct QueryOptions {
// KeywordSearchTermVisit is returned from GetMostRecentKeywordSearchTerms. It
// gives the time and search term of the keyword visit.
struct KeywordSearchTermVisit {
+ KeywordSearchTermVisit();
+ ~KeywordSearchTermVisit();
+
// The time of the visit.
base::Time time;
@@ -537,6 +540,9 @@ struct MostVisitedURL {
// Used by TopSites to store the thumbnails.
struct Images {
+ Images();
+ ~Images();
+
scoped_refptr<RefCountedBytes> thumbnail;
ThumbnailScore thumbnail_score;

Powered by Google App Engine
This is Rietveld 408576698