Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: webkit/appcache/appcache_storage.h

Issue 3522004: FBTF: Move ctors/dtors into implementation files. Adds ctors/dtors to non-POD structs. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/appcache/appcache_storage.h
diff --git a/webkit/appcache/appcache_storage.h b/webkit/appcache/appcache_storage.h
index 559237cd586cd3e348a8a92280f3ff5646d7bebb..20fbffe97d705da567bfee472764169614a707e6 100644
--- a/webkit/appcache/appcache_storage.h
+++ b/webkit/appcache/appcache_storage.h
@@ -206,11 +206,7 @@ class AppCacheStorage {
Delegate* delegate;
AppCacheStorage* storage;
- DelegateReference(Delegate* delegate, AppCacheStorage* storage)
- : delegate(delegate), storage(storage) {
- storage->delegate_references_.insert(
- DelegateReferenceMap::value_type(delegate, this));
- }
+ DelegateReference(Delegate* delegate, AppCacheStorage* storage);
void CancelReference() {
storage->delegate_references_.erase(delegate);
@@ -221,10 +217,7 @@ class AppCacheStorage {
private:
friend class base::RefCounted<DelegateReference>;
- ~DelegateReference() {
- if (delegate)
- storage->delegate_references_.erase(delegate);
- }
+ virtual ~DelegateReference();
};
typedef std::map<Delegate*, DelegateReference*> DelegateReferenceMap;
typedef std::vector<scoped_refptr<DelegateReference> >
@@ -236,6 +229,7 @@ class AppCacheStorage {
public:
ResponseInfoLoadTask(const GURL& manifest_url, int64 response_id,
AppCacheStorage* storage);
+ ~ResponseInfoLoadTask();
int64 response_id() const { return response_id_; }
const GURL& manifest_url() const { return manifest_url_; }

Powered by Google App Engine
This is Rietveld 408576698