Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1329001: ST1.5 board support and some ST1.0/1.5 common changes. (Closed)

Created:
10 years, 9 months ago by amoljadi
Modified:
9 years, 7 months ago
Reviewers:
robotboy, cros.approvers, micahc, Brian Daugherty, Michael Edwards, chromeboy
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

ST1.5 board support and some ST1.0/1.5 common changes. Following features working/verified on ST1.5: - Boot from external SD New in this patch: - ST1.5 support - new MMC framework (enabled) - DCC console support (default is "serial") Fixes: - ATAGs to kernel - SDCC stack corruption fix Not working/tested on ST1.5: - Boot from eMMC - Serial - USB - LCD - KBD - I2C - NAND support - Any other thing not mentioned in working/verified section.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1552 lines, -32 lines) Patch
M Makefile View 2 chunks +10 lines, -0 lines 0 comments Download
A board/chromeos_st15/Makefile View 1 chunk +47 lines, -0 lines 0 comments Download
A board/chromeos_st15/board.c View 1 chunk +294 lines, -0 lines 0 comments Download
A board/chromeos_st15/config.mk View 1 chunk +22 lines, -0 lines 0 comments Download
A board/chromeos_st15/memory_map.c View 1 chunk +94 lines, -0 lines 0 comments Download
A board/chromeos_st15/platform.S View 1 chunk +45 lines, -0 lines 0 comments Download
A board/chromeos_st15/u-boot.lds View 1 chunk +93 lines, -0 lines 0 comments Download
M board/chromeos_st1q/board.c View 1 chunk +0 lines, -4 lines 0 comments Download
M cpu/armv7Scorpion/QSD8x50/dram.c View 3 chunks +4 lines, -9 lines 0 comments Download
M cpu/armv7Scorpion/QSD8x50/lcdc.c View 3 chunks +3 lines, -2 lines 0 comments Download
M cpu/armv7Scorpion/QSD8x50/pll.c View 3 chunks +29 lines, -1 line 0 comments Download
M cpu/armv7Scorpion/QSD8x50/proc_comm_clients.c View 3 chunks +2 lines, -1 line 0 comments Download
M drivers/mmc/qsd_sdcc.c View 3 chunks +12 lines, -6 lines 0 comments Download
M drivers/serial/arm_dcc.c View 2 chunks +2 lines, -1 line 0 comments Download
A include/asm-arm/arch-QSD8x50/QSD8x50A_reg.h View 1 chunk +341 lines, -0 lines 0 comments Download
A include/configs/chromeos/st15/common.h View 1 chunk +269 lines, -0 lines 0 comments Download
A include/configs/chromeos/st15/fast.h View 1 chunk +64 lines, -0 lines 0 comments Download
A include/configs/chromeos/st15/recovery.h View 1 chunk +123 lines, -0 lines 0 comments Download
A include/configs/chromeos/st15/stub.h View 1 chunk +64 lines, -0 lines 0 comments Download
M include/configs/chromeos/st1q/common.h View 6 chunks +31 lines, -7 lines 0 comments Download
M include/configs/chromeos/st1q/recovery.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/lcd.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
amoljadi
10 years, 9 months ago (2010-03-25 01:01:57 UTC) #1
amoljadi
To build u-boot for ST1.5, this change also needs to go in: http://codereview.chromium.org/1231002 Plus we ...
10 years, 9 months ago (2010-03-25 02:38:00 UTC) #2
amoljadi
I am breaking this into multiple issues for easier review. I will cancel this review.
10 years, 9 months ago (2010-03-25 20:44:18 UTC) #3
robotboy
Thank you, thank you. :) -Anton On Thu, Mar 25, 2010 at 1:44 PM, <amoljadi@codeaurora.org> ...
10 years, 9 months ago (2010-03-25 21:09:29 UTC) #4
amoljadi
10 years, 9 months ago (2010-03-25 21:25:39 UTC) #5
No problem. Should have done that in the first place J

 

BTW, Do I need to Publish+Mail commets after I create the issue? Or just
adding the reviewers by doing "edit issue" will send out email? Apologies if
you are flooded with these multiple emails.

 

-Amol

 

From: robotboy@google.com [mailto:robotboy@google.com] On Behalf Of Anton
Staaf
Sent: Thursday, March 25, 2010 2:09 PM
To: amoljadi@codeaurora.org; robotboy@chromium.org; micahc@chromium.org;
medwards@codeaurora.org; bdaugher@codeaurora.org; pgargey@codeaurora.org;
cros.approvers@codeaurora.org; chromium-os-reviews@chromium.org
Subject: Re: ST1.5 board support and some ST1.0/1.5 common changes.
(issue1329001)

 

Thank you, thank you.  :)

 

-Anton

On Thu, Mar 25, 2010 at 1:44 PM, <amoljadi@codeaurora.org> wrote:

I am breaking this into multiple issues for easier review. I will cancel
this
review.



http://codereview.chromium.org/1329001

 

Powered by Google App Engine
This is Rietveld 408576698