Add ST1.5 variant

Add ST1.5 variant

[piman, 2010-03-24 00:33:06]

http://codereview.chromium.org/1231002/diff/1/2
File src/overlays/overlay-variant-st15q/make.conf (right):

http://codereview.chromium.org/1231002/diff/1/2#newcode1
src/overlays/overlay-variant-st15q/make.conf:1:
CHROMEOS_KERNEL="kernel-qualcomm"
You can actually drop all the lines that are common with the st1q main overlay,
this file is basically sourced after the other ones.
kernel config and portage binhost are probably enough

[Brian Daugherty, 2010-03-24 01:26:52]

On 2010/03/24 00:33:06, piman wrote:
> http://codereview.chromium.org/1231002/diff/1/2
> File src/overlays/overlay-variant-st15q/make.conf (right):
> 
> http://codereview.chromium.org/1231002/diff/1/2#newcode1
> src/overlays/overlay-variant-st15q/make.conf:1:
> CHROMEOS_KERNEL="kernel-qualcomm"
> You can actually drop all the lines that are common with the st1q main
overlay,
> this file is basically sourced after the other ones.
> kernel config and portage binhost are probably enough

u-boot differs between boards and has a different recovery config.

[piman, 2010-03-24 02:10:05]

http://codereview.chromium.org/1231002/diff/11001/12001
File src/overlays/overlay-variant-st1q-st15q/make.conf (right):

http://codereview.chromium.org/1231002/diff/11001/12001#newcode1
src/overlays/overlay-variant-st1q-st15q/make.conf:1:
CHROMEOS_KERNEL_CONFIG="qsd8650a-st1_5_defconfig"
Don't you need the splitconfig here ?

[Brian Daugherty, 2010-03-24 23:23:54]

On 2010/03/24 02:10:05, piman wrote:
> http://codereview.chromium.org/1231002/diff/11001/12001
> File src/overlays/overlay-variant-st1q-st15q/make.conf (right):
> 
> http://codereview.chromium.org/1231002/diff/11001/12001#newcode1
> src/overlays/overlay-variant-st1q-st15q/make.conf:1:
> CHROMEOS_KERNEL_CONFIG="qsd8650a-st1_5_defconfig"
> Don't you need the splitconfig here ?

Support for a single kernel config is added here,
http://codereview.chromium.org/1325001
Generating the ST1.5 split config is going to happen, but later when someone
frees up to test it. Short-term we can use a single config or comment the kernel
config out for ST1.5 and use the default.

[piman, 2010-03-25 00:35:44]

If 1325001 is fine, then LGTM.

[Mandeep Singh Baines, 2010-03-25 16:46:47]

On 2010/03/24 23:23:54, Brian Daugherty wrote:
> On 2010/03/24 02:10:05, piman wrote:
> > http://codereview.chromium.org/1231002/diff/11001/12001
> > File src/overlays/overlay-variant-st1q-st15q/make.conf (right):
> > 
> > http://codereview.chromium.org/1231002/diff/11001/12001#newcode1
> > src/overlays/overlay-variant-st1q-st15q/make.conf:1:
> > CHROMEOS_KERNEL_CONFIG="qsd8650a-st1_5_defconfig"
> > Don't you need the splitconfig here ?
> 
> Support for a single kernel config is added here,
> http://codereview.chromium.org/1325001
> Generating the ST1.5 split config is going to happen, but later when someone
> frees up to test it. Short-term we can use a single config or comment the
kernel
> config out for ST1.5 and use the default.

Please convert to a SPLITCONFIG. I can help with this on IRC. The testing can be
as simple as verifying that the .config generated by running make oldconfig on
the SPLITCONFIG is the same the as the .config generated from this config.

[robotboy, 2010-03-25 16:56:10]

To reiterate, we don't want to have any non-split configs in our builds.
 The ability to have a non-split config is a good feature for people that
want to build vanilla kernels, but we will not be using it for building
Chromium OS kernels.

Thanks,
    Anton

On Thu, Mar 25, 2010 at 9:46 AM, <msb@chromium.org> wrote:

> On 2010/03/24 23:23:54, Brian Daugherty wrote:
>
>> On 2010/03/24 02:10:05, piman wrote:
>> > http://codereview.chromium.org/1231002/diff/11001/12001
>> > File src/overlays/overlay-variant-st1q-st15q/make.conf (right):
>> >
>> > http://codereview.chromium.org/1231002/diff/11001/12001#newcode1
>> > src/overlays/overlay-variant-st1q-st15q/make.conf:1:
>> > CHROMEOS_KERNEL_CONFIG="qsd8650a-st1_5_defconfig"
>> > Don't you need the splitconfig here ?
>>
>
>  Support for a single kernel config is added here,
>> http://codereview.chromium.org/1325001
>> Generating the ST1.5 split config is going to happen, but later when
>> someone
>> frees up to test it. Short-term we can use a single config or comment the
>>
> kernel
>
>> config out for ST1.5 and use the default.
>>
>
> Please convert to a SPLITCONFIG. I can help with this on IRC. The testing
> can be
> as simple as verifying that the .config generated by running make oldconfig
> on
> the SPLITCONFIG is the same the as the .config generated from this config.
>
>
>
> http://codereview.chromium.org/1231002
>

[Brian Daugherty, 2010-03-25 23:08:44]

On 2010/03/25 16:56:10, robotboy wrote:
> To reiterate, we don't want to have any non-split configs in our builds.
>  The ability to have a non-split config is a good feature for people that
> want to build vanilla kernels, but we will not be using it for building
> Chromium OS kernels.
> 
> Thanks,
>     Anton
> 
> On Thu, Mar 25, 2010 at 9:46 AM, <mailto:msb@chromium.org> wrote:
> 
> > On 2010/03/24 23:23:54, Brian Daugherty wrote:
> >
> >> On 2010/03/24 02:10:05, piman wrote:
> >> > http://codereview.chromium.org/1231002/diff/11001/12001
> >> > File src/overlays/overlay-variant-st1q-st15q/make.conf (right):
> >> >
> >> > http://codereview.chromium.org/1231002/diff/11001/12001#newcode1
> >> > src/overlays/overlay-variant-st1q-st15q/make.conf:1:
> >> > CHROMEOS_KERNEL_CONFIG="qsd8650a-st1_5_defconfig"
> >> > Don't you need the splitconfig here ?
> >>
> >
> >  Support for a single kernel config is added here,
> >> http://codereview.chromium.org/1325001
> >> Generating the ST1.5 split config is going to happen, but later when
> >> someone
> >> frees up to test it. Short-term we can use a single config or comment the
> >>
> > kernel
> >
> >> config out for ST1.5 and use the default.
> >>
> >
> > Please convert to a SPLITCONFIG. I can help with this on IRC. The testing
> > can be
> > as simple as verifying that the .config generated by running make oldconfig
> > on
> > the SPLITCONFIG is the same the as the .config generated from this config.
> >
> >
> >
> > http://codereview.chromium.org/1231002
> >
> 

Now, with split-configs!

Any objection to committing make.conf as-is and continuing the integration
process?

[piman, 2010-03-25 23:18:57]

LGTM