Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1073005: Move RTL related functions from app/l10n_util to base/i18n/rtl... (Closed)

Created:
10 years, 9 months ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
CC:
chromium-reviews, jam+cc_chromium.org, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, Paul Godavari, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org
Visibility:
Public.

Description

Move RTL related functions from app/l10n_util to base/i18n/rtl TBR=darin BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42182

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+915 lines, -812 lines) Patch
M app/gfx/canvas.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M app/gfx/canvas.cc View 1 3 chunks +9 lines, -1 line 0 comments Download
M app/gfx/canvas_win.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M app/l10n_util.h View 1 2 chunks +0 lines, -98 lines 0 comments Download
M app/l10n_util.cc View 1 9 chunks +7 lines, -231 lines 0 comments Download
M app/l10n_util_dummy.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M app/l10n_util_unittest.cc View 1 2 chunks +0 lines, -242 lines 0 comments Download
M app/l10n_util_win.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M app/resource_bundle_linux.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M app/text_elider.h View 1 1 chunk +1 line, -1 line 0 comments Download
M app/text_elider.cc View 1 4 chunks +5 lines, -4 lines 0 comments Download
M app/text_elider_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M app/win_util.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M base/base.gyp View 1 2 chunks +3 lines, -0 lines 0 comments Download
M base/file_path.h View 1 1 chunk +1 line, -1 line 0 comments Download
A base/i18n/rtl.h View 1 1 chunk +121 lines, -0 lines 0 comments Download
A base/i18n/rtl.cc View 1 2 1 chunk +228 lines, -0 lines 0 comments Download
A base/i18n/rtl_unittest.cc View 1 1 chunk +258 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_table_model.cc View 1 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/browser_browsertest.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/browser_main_win.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/browser_theme_provider_gtk.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/compact_location_bar_host.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/location_bar_view_mac.mm View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/cookies_tree_model.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/chrome_url_data_manager.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/download/download_item_model.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/download/download_util.cc View 1 5 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/encoding_menu_controller.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/external_tab_container.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/find_bar_controller.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/gtk/bookmark_bubble_gtk.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/gtk/browser_toolbar_gtk.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/gtk/content_blocked_bubble_gtk.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/gtk/edit_search_engine_dialog.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/gtk/extension_installed_bubble_gtk.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/gtk/extension_popup_gtk.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/find_bar_gtk.cc View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/gtk/first_run_bubble.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/gtk/go_button_gtk.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/gtk/gtk_util.cc View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/gtk/location_bar_view_gtk.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/gtk/menu_gtk.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/gtk/nine_box.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/gtk/rounded_window.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/status_bubble_gtk.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/gtk/tab_contents_container_gtk.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/tabs/dragged_tab_gtk.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/tabs/tab_strip_gtk.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/language_combobox_model.cc View 1 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/possible_url_model.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 4 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/search_engines/template_url.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_table_model.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ssl/ssl_policy.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/task_manager.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/task_manager_resource_providers.cc View 1 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/views/about_chrome_view.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/views/bookmark_context_menu.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/download_item_view.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/views/edit_search_engine_dialog.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 1 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/views/go_button.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/views/hung_renderer_view.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/views/location_bar_view.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/views/options/advanced_contents_view.cc View 1 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/views/options/passwords_page_view.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/views/status_bubble_views.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/views/tabs/dragged_tab_controller.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/child_process_info.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_message_bundle.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_message_bundle_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/renderer/localized_error.cc View 1 5 chunks +7 lines, -6 lines 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M views/accelerator.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M views/controls/button/native_button.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M views/controls/button/text_button.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M views/controls/combobox/native_combobox_win.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M views/controls/label.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M views/controls/label_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/menu/menu.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M views/controls/menu/menu_controller.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M views/controls/menu/native_menu_gtk.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/message_box_view.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M views/controls/table/table_view.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M views/controls/textfield/native_textfield_win.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M views/controls/tree/tree_view.cc View 1 4 chunks +4 lines, -3 lines 0 comments Download
M views/view.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M views/widget/tooltip_manager_win.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M views/window/window_gtk.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M views/window/window_win.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
10 years, 9 months ago (2010-03-20 06:34:56 UTC) #1
darin (slow to review)
10 years, 9 months ago (2010-03-22 20:32:59 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698