Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: views/controls/message_box_view.cc

Issue 1073005: Move RTL related functions from app/l10n_util to base/i18n/rtl... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « views/controls/menu/native_menu_gtk.cc ('k') | views/controls/table/table_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/controls/message_box_view.cc
===================================================================
--- views/controls/message_box_view.cc (revision 42180)
+++ views/controls/message_box_view.cc (working copy)
@@ -6,8 +6,8 @@
#include "app/clipboard/clipboard.h"
#include "app/clipboard/scoped_clipboard_writer.h"
-#include "app/l10n_util.h"
#include "app/message_box_flags.h"
+#include "base/i18n/rtl.h"
#include "base/message_loop.h"
#include "base/utf_string_conversions.h"
#include "views/controls/button/checkbox.h"
@@ -120,10 +120,10 @@
if (dialog_flags & MessageBoxFlags::kAutoDetectAlignment) {
// Determine the alignment and directionality based on the first character
// with strong directionality.
- l10n_util::TextDirection direction =
- l10n_util::GetFirstStrongCharacterDirection(message_label_->GetText());
+ base::i18n::TextDirection direction =
+ base::i18n::GetFirstStrongCharacterDirection(message_label_->GetText());
views::Label::Alignment alignment;
- if (direction == l10n_util::RIGHT_TO_LEFT)
+ if (direction == base::i18n::RIGHT_TO_LEFT)
alignment = views::Label::ALIGN_RIGHT;
else
alignment = views::Label::ALIGN_LEFT;
« no previous file with comments | « views/controls/menu/native_menu_gtk.cc ('k') | views/controls/table/table_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698