Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: views/controls/label_unittest.cc

Issue 1073005: Move RTL related functions from app/l10n_util to base/i18n/rtl... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « views/controls/label.cc ('k') | views/controls/menu/menu.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/controls/label_unittest.cc
===================================================================
--- views/controls/label_unittest.cc (revision 42180)
+++ views/controls/label_unittest.cc (working copy)
@@ -4,6 +4,7 @@
#include "app/gfx/canvas.h"
#include "app/l10n_util.h"
+#include "base/i18n/rtl.h"
#include "base/utf_string_conversions.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "views/border.h"
@@ -65,8 +66,7 @@
TEST(LabelTest, AlignmentProperty) {
Label label;
- bool reverse_alignment =
- l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT;
+ bool reverse_alignment = base::i18n::IsRTL();
label.SetHorizontalAlignment(Label::ALIGN_RIGHT);
EXPECT_EQ(
« no previous file with comments | « views/controls/label.cc ('k') | views/controls/menu/menu.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698