Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/browser/renderer_host/render_view_host.cc

Issue 1073005: Move RTL related functions from app/l10n_util to base/i18n/rtl... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/possible_url_model.cc ('k') | chrome/browser/renderer_host/render_widget_host_view_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/render_view_host.cc
===================================================================
--- chrome/browser/renderer_host/render_view_host.cc (revision 42180)
+++ chrome/browser/renderer_host/render_view_host.cc (working copy)
@@ -8,8 +8,8 @@
#include <utility>
#include <vector>
-#include "app/l10n_util.h"
#include "app/resource_bundle.h"
+#include "base/i18n/rtl.h"
#include "base/json/json_reader.h"
#include "base/stats_counters.h"
#include "base/string_util.h"
@@ -1297,13 +1297,13 @@
std::wstring wrapped_tooltip_text = tooltip_text;
if (!tooltip_text.empty()) {
if (text_direction_hint == WebKit::WebTextDirectionLeftToRight &&
- l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT) {
+ base::i18n::IsRTL()) {
// Force the tooltip to have LTR directionality.
- l10n_util::WrapStringWithLTRFormatting(&wrapped_tooltip_text);
+ base::i18n::WrapStringWithLTRFormatting(&wrapped_tooltip_text);
} else if (text_direction_hint == WebKit::WebTextDirectionRightToLeft &&
- l10n_util::GetTextDirection() == l10n_util::LEFT_TO_RIGHT) {
+ !base::i18n::IsRTL()) {
// Force the tooltip to have RTL directionality.
- l10n_util::WrapStringWithRTLFormatting(&wrapped_tooltip_text);
+ base::i18n::WrapStringWithRTLFormatting(&wrapped_tooltip_text);
}
}
if (view())
« no previous file with comments | « chrome/browser/possible_url_model.cc ('k') | chrome/browser/renderer_host/render_widget_host_view_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698