Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3785)

Unified Diff: chrome/browser/task_manager_resource_providers.cc

Issue 1073005: Move RTL related functions from app/l10n_util to base/i18n/rtl... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/task_manager.cc ('k') | chrome/browser/views/about_chrome_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_manager_resource_providers.cc
===================================================================
--- chrome/browser/task_manager_resource_providers.cc (revision 42180)
+++ chrome/browser/task_manager_resource_providers.cc (working copy)
@@ -10,6 +10,7 @@
#include "app/resource_bundle.h"
#include "base/basictypes.h"
#include "base/file_version_info.h"
+#include "base/i18n/rtl.h"
#include "base/process_util.h"
#include "base/stl_util-inl.h"
#include "base/string_util.h"
@@ -73,8 +74,8 @@
if (tab_title.empty()) {
tab_title = UTF8ToWide(tab_contents_->GetURL().spec());
// Force URL to be LTR.
- if (l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT)
- l10n_util::WrapStringWithLTRFormatting(&tab_title);
+ if (base::i18n::IsRTL())
+ base::i18n::WrapStringWithLTRFormatting(&tab_title);
} else {
// Since the tab_title will be concatenated with
// IDS_TASK_MANAGER_TAB_PREFIX, we need to explicitly set the tab_title to
@@ -85,7 +86,7 @@
// as LTR format, the concatenated result will be "!Yahoo! Mail: The best
// web-based Email :BAT", in which the capital letters "BAT" stands for
// the Hebrew word for "tab".
- l10n_util::AdjustStringForLocaleDirection(tab_title, &tab_title);
+ base::i18n::AdjustStringForLocaleDirection(tab_title, &tab_title);
}
return l10n_util::GetStringF(IDS_TASK_MANAGER_TAB_PREFIX, tab_title);
@@ -532,7 +533,7 @@
// "Great Extension!" the concatenated result would be something like
// "!Great Extension :NOISNETXE", in which capital letters "NOISNETXE"
// stand for the Hebrew word for "extension".
- l10n_util::AdjustStringForLocaleDirection(extension_name, &extension_name);
+ base::i18n::AdjustStringForLocaleDirection(extension_name, &extension_name);
title_ = l10n_util::GetStringF(IDS_TASK_MANAGER_EXTENSION_PREFIX,
extension_name);
}
« no previous file with comments | « chrome/browser/task_manager.cc ('k') | chrome/browser/views/about_chrome_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698