Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: chrome/browser/views/about_chrome_view.cc

Issue 1073005: Move RTL related functions from app/l10n_util to base/i18n/rtl... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/views/about_chrome_view.cc
===================================================================
--- chrome/browser/views/about_chrome_view.cc (revision 42180)
+++ chrome/browser/views/about_chrome_view.cc (working copy)
@@ -10,6 +10,7 @@
#include "app/resource_bundle.h"
#include "base/callback.h"
#include "base/file_version_info.h"
+#include "base/i18n/rtl.h"
#include "base/i18n/word_iterator.h"
#include "base/utf_string_conversions.h"
#include "chrome/browser/browser_list.h"
@@ -127,8 +128,7 @@
}
void AboutChromeView::Init() {
- text_direction_is_rtl_ =
- l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT;
+ text_direction_is_rtl_ = base::i18n::IsRTL();
ResourceBundle& rb = ResourceBundle::GetSharedInstance();
scoped_ptr<FileVersionInfo> version_info(
@@ -871,9 +871,9 @@
l10n_util::GetStringF(IDS_UPGRADE_ALREADY_UP_TO_DATE,
l10n_util::GetString(IDS_PRODUCT_NAME),
current_version_);
- if (l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT) {
+ if (base::i18n::IsRTL()) {
update_label_text.push_back(
- static_cast<wchar_t>(l10n_util::kLeftToRightMark));
+ static_cast<wchar_t>(base::i18n::kLeftToRightMark));
}
update_label_.SetText(update_label_text);
show_success_indicator = true;

Powered by Google App Engine
This is Rietveld 408576698