Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: views/accelerator.cc

Issue 1073005: Move RTL related functions from app/l10n_util to base/i18n/rtl... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/automation/automation_proxy_uitest.cc ('k') | views/controls/button/native_button.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/accelerator.cc
===================================================================
--- views/accelerator.cc (revision 42180)
+++ views/accelerator.cc (working copy)
@@ -9,6 +9,7 @@
#endif
#include "app/l10n_util.h"
+#include "base/i18n/rtl.h"
#include "base/logging.h"
#include "base/string_util.h"
#include "grit/app_strings.h"
@@ -92,10 +93,8 @@
// required.
std::wstring shortcut_rtl;
bool adjust_shortcut_for_rtl = false;
- if (l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT &&
- shortcut.length() == 1 &&
- !IsAsciiAlpha(shortcut.at(0)) &&
- !IsAsciiDigit(shortcut.at(0))) {
+ if (base::i18n::IsRTL() && shortcut.length() == 1 &&
+ !IsAsciiAlpha(shortcut.at(0)) && !IsAsciiDigit(shortcut.at(0))) {
adjust_shortcut_for_rtl = true;
shortcut_rtl.assign(shortcut);
}
« no previous file with comments | « chrome/test/automation/automation_proxy_uitest.cc ('k') | views/controls/button/native_button.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698