Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: chrome/browser/cookies_tree_model.cc

Issue 1073005: Move RTL related functions from app/l10n_util to base/i18n/rtl... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/cookies_tree_model.h" 5 #include "chrome/browser/cookies_tree_model.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <functional> 8 #include <functional>
9 #include <vector> 9 #include <vector>
10 10
11 #include "app/l10n_util.h" 11 #include "app/l10n_util.h"
12 #include "app/resource_bundle.h" 12 #include "app/resource_bundle.h"
13 #include "app/table_model_observer.h" 13 #include "app/table_model_observer.h"
14 #include "app/tree_node_model.h" 14 #include "app/tree_node_model.h"
15 #include "base/callback.h" 15 #include "base/callback.h"
16 #include "base/i18n/rtl.h"
16 #include "base/linked_ptr.h" 17 #include "base/linked_ptr.h"
17 #include "base/string_util.h" 18 #include "base/string_util.h"
18 #include "chrome/browser/extensions/extensions_service.h" 19 #include "chrome/browser/extensions/extensions_service.h"
19 #include "chrome/browser/in_process_webkit/webkit_context.h" 20 #include "chrome/browser/in_process_webkit/webkit_context.h"
20 #include "chrome/browser/net/chrome_url_request_context.h" 21 #include "chrome/browser/net/chrome_url_request_context.h"
21 #include "chrome/browser/profile.h" 22 #include "chrome/browser/profile.h"
22 #include "grit/app_resources.h" 23 #include "grit/app_resources.h"
23 #include "grit/generated_resources.h" 24 #include "grit/generated_resources.h"
24 #include "grit/theme_resources.h" 25 #include "grit/theme_resources.h"
25 #include "net/base/cookie_monster.h" 26 #include "net/base/cookie_monster.h"
(...skipping 557 matching lines...) Expand 10 before | Expand all | Expand 10 after
583 UTF8ToWide(extension->name()) : 584 UTF8ToWide(extension->name()) :
584 l10n_util::GetString(IDS_UNKNOWN_PLUGIN_NAME); 585 l10n_util::GetString(IDS_UNKNOWN_PLUGIN_NAME);
585 586
586 // Since the extension_name will be concatenated with a prefix, we need 587 // Since the extension_name will be concatenated with a prefix, we need
587 // to explicitly set the extension_name to be LTR format if there is no 588 // to explicitly set the extension_name to be LTR format if there is no
588 // strong RTL charater in it. Otherwise, if the prefix is an RTL word, 589 // strong RTL charater in it. Otherwise, if the prefix is an RTL word,
589 // the concatenated result might be wrong. For extension named 590 // the concatenated result might be wrong. For extension named
590 // "Great Extension!" the concatenated result would be something like 591 // "Great Extension!" the concatenated result would be something like
591 // "!Great Extension :NOISNETXE", in which capital letters "NOISNETXE" 592 // "!Great Extension :NOISNETXE", in which capital letters "NOISNETXE"
592 // stand for the Hebrew word for "extension". 593 // stand for the Hebrew word for "extension".
593 l10n_util::AdjustStringForLocaleDirection(extension_name, &extension_name); 594 base::i18n::AdjustStringForLocaleDirection(extension_name, &extension_name);
594 return l10n_util::GetStringF(IDS_TASK_MANAGER_EXTENSION_PREFIX, 595 return l10n_util::GetStringF(IDS_TASK_MANAGER_EXTENSION_PREFIX,
595 extension_name); 596 extension_name);
596 } 597 }
OLDNEW
« no previous file with comments | « chrome/browser/cocoa/location_bar_view_mac.mm ('k') | chrome/browser/dom_ui/chrome_url_data_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698