Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: chrome/browser/views/options/passwords_page_view.cc

Issue 1073005: Move RTL related functions from app/l10n_util to base/i18n/rtl... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/options/advanced_contents_view.cc ('k') | chrome/browser/views/status_bubble_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/options/passwords_page_view.cc
===================================================================
--- chrome/browser/views/options/passwords_page_view.cc (revision 42180)
+++ chrome/browser/views/options/passwords_page_view.cc (working copy)
@@ -5,6 +5,7 @@
#include "chrome/browser/views/options/passwords_page_view.h"
#include "app/l10n_util.h"
+#include "base/i18n/rtl.h"
#include "base/string_util.h"
#include "chrome/browser/password_manager/password_store.h"
#include "chrome/browser/pref_service.h"
@@ -71,16 +72,16 @@
case IDS_PASSWORDS_PAGE_VIEW_SITE_COLUMN: { // Site.
const std::wstring& url = saved_signons_[row]->display_url.display_url();
// Force URL to have LTR directionality.
- if (l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT) {
+ if (base::i18n::IsRTL()) {
std::wstring localized_url = url;
- l10n_util::WrapStringWithLTRFormatting(&localized_url);
+ base::i18n::WrapStringWithLTRFormatting(&localized_url);
return localized_url;
}
return url;
}
case IDS_PASSWORDS_PAGE_VIEW_USERNAME_COLUMN: { // Username.
std::wstring username = GetPasswordFormAt(row)->username_value;
- l10n_util::AdjustStringForLocaleDirection(username, &username);
+ base::i18n::AdjustStringForLocaleDirection(username, &username);
return username;
}
default:
« no previous file with comments | « chrome/browser/views/options/advanced_contents_view.cc ('k') | chrome/browser/views/status_bubble_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698