Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed)

Created:
8 years, 8 months ago by Ryan Sleevi
Modified:
8 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, michaeln, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, dcheng, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, kinuko+watch, James Su
Visibility:
Public.

Description

RefCounted types should not have public destructors, content/browser part 1 BUG=123295 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134395

Patch Set 1 #

Patch Set 2 : Implementation ordering #

Total comments: 1

Patch Set 3 : Feedback #

Patch Set 4 : MSVC fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+615 lines, -444 lines) Patch
M content/browser/appcache/appcache_dispatcher_host.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache_dispatcher_host.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/appcache/chrome_appcache_service.h View 1 2 3 1 chunk +13 lines, -8 lines 0 comments Download
M content/browser/appcache/chrome_appcache_service.cc View 1 2 chunks +11 lines, -12 lines 0 comments Download
M content/browser/browser_thread_unittest.cc View 3 chunks +11 lines, -1 line 0 comments Download
M content/browser/device_orientation/device_orientation_browsertest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/device_orientation/provider_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/download/download_net_log_parameters.h View 1 2 3 11 chunks +33 lines, -1 line 0 comments Download
M content/browser/download/download_net_log_parameters.cc View 1 12 chunks +22 lines, -3 lines 0 comments Download
M content/browser/download/drag_download_util.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/download/drag_download_util.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
M content/browser/fileapi/chrome_blob_storage_context.h View 1 2 3 1 chunk +10 lines, -5 lines 0 comments Download
M content/browser/fileapi/chrome_blob_storage_context.cc View 1 2 chunks +3 lines, -5 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 1 3 chunks +8 lines, -9 lines 0 comments Download
M content/browser/geolocation/arbitrator_dependency_factories_for_test.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/geolocation/arbitrator_dependency_factories_for_test.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/geolocation/arbitrator_dependency_factory.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/geolocation/arbitrator_dependency_factory.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/geolocation/geolocation_provider_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/geolocation/location_arbitrator_unittest.cc View 1 3 chunks +7 lines, -0 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_common_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_context_impl.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_context_impl.cc View 1 5 chunks +64 lines, -64 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_key_utility_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_quota_client.cc View 6 chunks +23 lines, -0 lines 0 comments Download
M content/browser/indexed_db/idbbindingutilities_browsertest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 1 4 chunks +8 lines, -9 lines 0 comments Download
M content/browser/plugin_loader_posix_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/profiler_message_filter.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/profiler_message_filter.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host_unittest.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_device_settings.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.cc View 1 2 chunks +112 lines, -113 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.h View 1 3 chunks +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 1 6 chunks +54 lines, -56 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host_unittest.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_dispatcher_host.h View 1 3 chunks +7 lines, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_dispatcher_host.cc View 1 5 chunks +41 lines, -41 lines 0 comments Download
M content/browser/renderer_host/pepper_file_message_filter.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/pepper_file_message_filter.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/pepper_message_filter.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/pepper_message_filter.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/quota_dispatcher_host.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M content/browser/renderer_host/quota_dispatcher_host.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_unittest.cc View 2 chunks +8 lines, -1 line 0 comments Download
M content/browser/renderer_host/socket_stream_dispatcher_host.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/socket_stream_dispatcher_host.cc View 1 2 chunks +12 lines, -12 lines 0 comments Download
M content/browser/renderer_host/text_input_client_message_filter.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/text_input_client_message_filter.mm View 1 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/resolve_proxy_msg_helper.h View 1 1 chunk +5 lines, -4 lines 0 comments Download
M content/browser/resolve_proxy_msg_helper.cc View 1 2 chunks +17 lines, -17 lines 0 comments Download
M content/browser/speech/speech_recognizer_impl.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/speech/speech_recognizer_impl.cc View 1 3 chunks +9 lines, -9 lines 0 comments Download
M content/browser/trace_message_filter.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/trace_message_filter.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/trace_subscriber_stdio.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ryan Sleevi
sky: PTAL
8 years, 8 months ago (2012-04-13 09:23:40 UTC) #1
sky
Same comment as other, move implementation to match and make sure clang bots are ok ...
8 years, 8 months ago (2012-04-13 15:51:43 UTC) #2
Ryan Sleevi
Comments addressed, PTAL
8 years, 8 months ago (2012-04-27 01:36:32 UTC) #3
sky
LGTM http://codereview.chromium.org/10068037/diff/3001/content/browser/renderer_host/media/audio_renderer_host_unittest.cc File content/browser/renderer_host/media/audio_renderer_host_unittest.cc (right): http://codereview.chromium.org/10068037/diff/3001/content/browser/renderer_host/media/audio_renderer_host_unittest.cc#newcode68 content/browser/renderer_host/media/audio_renderer_host_unittest.cc:68: EXPECT_EQ(0u, audio_entries_.size()); nit: empty
8 years, 8 months ago (2012-04-27 15:45:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10068037/8001
8 years, 8 months ago (2012-04-27 19:43:55 UTC) #5
commit-bot: I haz the power
Try job failure for 10068037-8001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-27 20:39:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10068037/14001
8 years, 8 months ago (2012-04-27 21:38:40 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-27 23:40:59 UTC) #8
Change committed as 134395

Powered by Google App Engine
This is Rietveld 408576698