Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Unified Diff: content/browser/browser_thread_unittest.cc

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: MSVC fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_thread_unittest.cc
diff --git a/content/browser/browser_thread_unittest.cc b/content/browser/browser_thread_unittest.cc
index 6bb8e5aad985e2b84a005a7333e7b4e5900737e8..57a7b521cda6586eec7ea1b15952f8e274d3b366 100644
--- a/content/browser/browser_thread_unittest.cc
+++ b/content/browser/browser_thread_unittest.cc
@@ -7,6 +7,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/message_loop.h"
#include "base/message_loop_proxy.h"
+#include "base/sequenced_task_runner_helpers.h"
#include "content/browser/browser_thread_impl.h"
#include "content/test/test_browser_thread.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -46,12 +47,15 @@ class BrowserThreadTest : public testing::Test {
explicit DeletedOnFile(MessageLoop* message_loop)
: message_loop_(message_loop) { }
+ private:
+ friend struct BrowserThread::DeleteOnThread<BrowserThread::FILE>;
+ friend class base::DeleteHelper<DeletedOnFile>;
+
~DeletedOnFile() {
CHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
message_loop_->PostTask(FROM_HERE, MessageLoop::QuitClosure());
}
- private:
MessageLoop* message_loop_;
};
@@ -59,6 +63,12 @@ class BrowserThreadTest : public testing::Test {
: public base::RefCountedThreadSafe<
NeverDeleted, BrowserThread::DeleteOnWebKitThread> {
public:
+
+ private:
+ friend struct BrowserThread::DeleteOnThread<
+ BrowserThread::WEBKIT_DEPRECATED>;
+ friend class base::DeleteHelper<NeverDeleted>;
+
~NeverDeleted() {
CHECK(false);
}

Powered by Google App Engine
This is Rietveld 408576698