RefCounted types should not have public destructors, content/browser part 1

content/browser/browser_thread_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/message_loop_proxy.h"
+#include "base/sequenced_task_runner_helpers.h"
 #include "content/browser/browser_thread_impl.h"
 #include "content/test/test_browser_thread.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/platform_test.h"
 
 namespace content {
 
 class BrowserThreadTest : public testing::Test {
  public:
   void Release() const {
@@ skipping 19 matching lines @@
     message_loop->PostTask(FROM_HERE, MessageLoop::QuitClosure());
   }
 
   class DeletedOnFile
       : public base::RefCountedThreadSafe<
             DeletedOnFile, BrowserThread::DeleteOnFileThread> {
    public:
     explicit DeletedOnFile(MessageLoop* message_loop)
         : message_loop_(message_loop) { }
 
+   private:
+    friend struct BrowserThread::DeleteOnThread<BrowserThread::FILE>;
+    friend class base::DeleteHelper<DeletedOnFile>;
+
     ~DeletedOnFile() {
       CHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
       message_loop_->PostTask(FROM_HERE, MessageLoop::QuitClosure());
     }
 
-   private:
     MessageLoop* message_loop_;
   };
 
   class NeverDeleted
       : public base::RefCountedThreadSafe<
             NeverDeleted, BrowserThread::DeleteOnWebKitThread> {
    public:
+
+   private:
+    friend struct BrowserThread::DeleteOnThread<
+        BrowserThread::WEBKIT_DEPRECATED>;
+    friend class base::DeleteHelper<NeverDeleted>;
+
     ~NeverDeleted() {
       CHECK(false);
     }
   };
 
  private:
   scoped_ptr<BrowserThreadImpl> ui_thread_;
   scoped_ptr<BrowserThreadImpl> file_thread_;
   // It's kind of ugly to make this mutable - solely so we can post the Quit
   // Task from Release(). This should be fixed.
@@ skipping 45 matching lines @@
   ASSERT_TRUE(BrowserThread::PostTaskAndReply(
       BrowserThread::FILE,
       FROM_HERE,
       base::Bind(&base::DoNothing),
       base::Bind(&MessageLoop::Quit,
                  base::Unretained(MessageLoop::current()->current()))));
   MessageLoop::current()->Run();
 }
 
 }