Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: content/browser/fileapi/fileapi_message_filter.cc

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: MSVC fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/fileapi/fileapi_message_filter.cc
diff --git a/content/browser/fileapi/fileapi_message_filter.cc b/content/browser/fileapi/fileapi_message_filter.cc
index e3203c2773deaea74ac17b1f5ddc6a8e64ccc8b7..3ce1d18facf7b90838cdb115343f20e94834ad2c 100644
--- a/content/browser/fileapi/fileapi_message_filter.cc
+++ b/content/browser/fileapi/fileapi_message_filter.cc
@@ -97,9 +97,6 @@ FileAPIMessageFilter::FileAPIMessageFilter(
DCHECK(blob_storage_context);
}
-FileAPIMessageFilter::~FileAPIMessageFilter() {
-}
-
void FileAPIMessageFilter::OnChannelConnected(int32 peer_pid) {
BrowserMessageFilter::OnChannelConnected(peer_pid);
@@ -165,6 +162,14 @@ bool FileAPIMessageFilter::OnMessageReceived(
return handled;
}
+void FileAPIMessageFilter::UnregisterOperation(int request_id) {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK(operations_.Lookup(request_id));
+ operations_.Remove(request_id);
+}
+
+FileAPIMessageFilter::~FileAPIMessageFilter() {}
+
void FileAPIMessageFilter::OnOpen(
int request_id, const GURL& origin_url, fileapi::FileSystemType type,
int64 requested_size, bool create) {
@@ -672,9 +677,3 @@ FileSystemOperationInterface* FileAPIMessageFilter::GetNewOperation(
operations_.AddWithID(operation, request_id);
return operation;
}
-
-void FileAPIMessageFilter::UnregisterOperation(int request_id) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
- DCHECK(operations_.Lookup(request_id));
- operations_.Remove(request_id);
-}

Powered by Google App Engine
This is Rietveld 408576698