Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Unified Diff: content/browser/download/download_net_log_parameters.cc

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: MSVC fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_net_log_parameters.cc
diff --git a/content/browser/download/download_net_log_parameters.cc b/content/browser/download/download_net_log_parameters.cc
index 8211cfc966ebde8827a8a2accf23cfc7d7effc46..244a38fc8b026934493169dc0be3b461ee1e4037 100644
--- a/content/browser/download/download_net_log_parameters.cc
+++ b/content/browser/download/download_net_log_parameters.cc
@@ -64,9 +64,6 @@ ItemActivatedParameters::ItemActivatedParameters(
start_offset_(start_offset) {
}
-ItemActivatedParameters::~ItemActivatedParameters() {
-}
-
Value* ItemActivatedParameters::ToValue() const {
DictionaryValue* dict = new DictionaryValue();
@@ -82,6 +79,8 @@ Value* ItemActivatedParameters::ToValue() const {
return dict;
}
+ItemActivatedParameters::~ItemActivatedParameters() {}
+
ItemCheckedParameters::ItemCheckedParameters(
content::DownloadDangerType danger_type,
content::DownloadItem::SafetyState safety_state)
@@ -97,6 +96,8 @@ Value* ItemCheckedParameters::ToValue() const {
return dict;
}
+ItemCheckedParameters::~ItemCheckedParameters() {}
+
ItemInHistoryParameters::ItemInHistoryParameters(int64 handle)
: db_handle_(handle) {
}
@@ -109,6 +110,8 @@ Value* ItemInHistoryParameters::ToValue() const {
return dict;
}
+ItemInHistoryParameters::~ItemInHistoryParameters() {}
+
ItemUpdatedParameters::ItemUpdatedParameters(int64 bytes_so_far)
: bytes_so_far_(bytes_so_far) {
}
@@ -121,6 +124,8 @@ Value* ItemUpdatedParameters::ToValue() const {
return dict;
}
+ItemUpdatedParameters::~ItemUpdatedParameters() {}
+
ItemRenamedParameters::ItemRenamedParameters(
const std::string& old_filename, const std::string& new_filename)
: old_filename_(old_filename), new_filename_(new_filename) {
@@ -135,6 +140,8 @@ Value* ItemRenamedParameters::ToValue() const {
return dict;
}
+ItemRenamedParameters::~ItemRenamedParameters() {}
+
ItemInterruptedParameters::ItemInterruptedParameters(
content::DownloadInterruptReason reason,
int64 bytes_so_far,
@@ -155,6 +162,8 @@ Value* ItemInterruptedParameters::ToValue() const {
return dict;
}
+ItemInterruptedParameters::~ItemInterruptedParameters() {}
+
ItemFinishedParameters::ItemFinishedParameters(
int64 bytes_so_far,
const std::string& final_hash)
@@ -172,6 +181,8 @@ Value* ItemFinishedParameters::ToValue() const {
return dict;
}
+ItemFinishedParameters::~ItemFinishedParameters() {}
+
ItemCanceledParameters::ItemCanceledParameters(
int64 bytes_so_far,
const std::string& hash_state)
@@ -189,6 +200,8 @@ Value* ItemCanceledParameters::ToValue() const {
return dict;
}
+ItemCanceledParameters::~ItemCanceledParameters() {}
+
FileOpenedParameters::FileOpenedParameters(const std::string& file_name,
int64 start_offset)
: file_name_(file_name), start_offset_(start_offset) {
@@ -203,6 +216,8 @@ Value* FileOpenedParameters::ToValue() const {
return dict;
}
+FileOpenedParameters::~FileOpenedParameters() {}
+
FileRenamedParameters::FileRenamedParameters(
const std::string& old_filename, const std::string& new_filename)
: old_filename_(old_filename), new_filename_(new_filename) {
@@ -217,6 +232,8 @@ Value* FileRenamedParameters::ToValue() const {
return dict;
}
+FileRenamedParameters::~FileRenamedParameters() {}
+
FileErrorParameters::FileErrorParameters(const std::string& operation,
net::Error net_error)
: operation_(operation), net_error_(net_error) {
@@ -231,4 +248,6 @@ Value* FileErrorParameters::ToValue() const {
return dict;
}
+FileErrorParameters::~FileErrorParameters() {}
+
} // namespace download_net_logs
« no previous file with comments | « content/browser/download/download_net_log_parameters.h ('k') | content/browser/download/drag_download_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698