Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: content/browser/geolocation/location_arbitrator_unittest.cc

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: MSVC fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/geolocation/location_arbitrator_unittest.cc
diff --git a/content/browser/geolocation/location_arbitrator_unittest.cc b/content/browser/geolocation/location_arbitrator_unittest.cc
index ab7d7ea83a7c4764a4449b75c081a2a86473113f..08caed51f9e39fc267abd69836dd2bf4c9c97229 100644
--- a/content/browser/geolocation/location_arbitrator_unittest.cc
+++ b/content/browser/geolocation/location_arbitrator_unittest.cc
@@ -70,12 +70,15 @@ class MockDependencyFactory : public GeolocationArbitratorDependencyFactory {
gps_(NULL),
access_token_store_(access_token_store) {
}
+
virtual GeolocationArbitrator::GetTimeNow GetTimeFunction() {
return GetTimeNowForTest;
}
+
virtual AccessTokenStore* NewAccessTokenStore() {
return access_token_store_.get();
}
+
virtual LocationProviderBase* NewNetworkLocationProvider(
AccessTokenStore* access_token_store,
net::URLRequestContextGetter* context,
@@ -83,6 +86,7 @@ class MockDependencyFactory : public GeolocationArbitratorDependencyFactory {
const string16& access_token) {
return new MockLocationProvider(&cell_);
}
+
virtual LocationProviderBase* NewSystemLocationProvider() {
return new MockLocationProvider(&gps_);
}
@@ -95,6 +99,9 @@ class MockDependencyFactory : public GeolocationArbitratorDependencyFactory {
MockLocationProvider* gps_;
scoped_refptr<AccessTokenStore> access_token_store_;
+
+ private:
+ virtual ~MockDependencyFactory() {}
};
class GeolocationLocationArbitratorTest : public testing::Test {

Powered by Google App Engine
This is Rietveld 408576698