Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: content/browser/plugin_data_remover_impl.cc

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: MSVC fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/plugin_data_remover_impl.cc
diff --git a/content/browser/plugin_data_remover_impl.cc b/content/browser/plugin_data_remover_impl.cc
index 42079cf3e54312313dee3c30f99e31df35d02fe2..f4eab9f809b8a2b9077c5fd1dd5b3da40085c412 100644
--- a/content/browser/plugin_data_remover_impl.cc
+++ b/content/browser/plugin_data_remover_impl.cc
@@ -6,6 +6,7 @@
#include "base/bind.h"
#include "base/metrics/histogram.h"
+#include "base/sequenced_task_runner_helpers.h"
#include "base/synchronization/waitable_event.h"
#include "base/utf_string_conversions.h"
#include "base/version.h"
@@ -73,9 +74,6 @@ class PluginDataRemoverImpl::Context
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
}
- virtual ~Context() {
- }
-
void Init(const std::string& mime_type) {
BrowserThread::PostTask(
BrowserThread::IO,
@@ -139,14 +137,11 @@ class PluginDataRemoverImpl::Context
return resource_context_;
}
- virtual void SetPluginInfo(const webkit::WebPluginInfo& info) OVERRIDE {
- }
+ virtual void SetPluginInfo(const webkit::WebPluginInfo& info) OVERRIDE {}
- virtual void OnFoundPluginProcessHost(PluginProcessHost* host) OVERRIDE {
- }
+ virtual void OnFoundPluginProcessHost(PluginProcessHost* host) OVERRIDE {}
- virtual void OnSentPluginChannelRequest() OVERRIDE {
- }
+ virtual void OnSentPluginChannelRequest() OVERRIDE {}
virtual void OnChannelOpened(const IPC::ChannelHandle& handle) OVERRIDE {
ConnectToChannel(handle, false);
@@ -201,6 +196,10 @@ class PluginDataRemoverImpl::Context
base::WaitableEvent* event() { return event_.get(); }
private:
+ friend struct BrowserThread::DeleteOnThread<BrowserThread::IO>;
+ friend class base::DeleteHelper<Context>;
+ virtual ~Context() {}
+
// Connects the client side of a newly opened plug-in channel.
void ConnectToChannel(const IPC::ChannelHandle& handle, bool is_ppapi) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
« no previous file with comments | « content/browser/indexed_db/idbbindingutilities_browsertest.cc ('k') | content/browser/plugin_loader_posix_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698