Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: content/browser/in_process_webkit/indexed_db_key_utility_client.cc

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: MSVC fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/in_process_webkit/indexed_db_key_utility_client.h" 5 #include "content/browser/in_process_webkit/indexed_db_key_utility_client.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/lazy_instance.h" 8 #include "base/lazy_instance.h"
9 #include "base/synchronization/waitable_event.h" 9 #include "base/synchronization/waitable_event.h"
10 #include "content/browser/utility_process_host_impl.h" 10 #include "content/browser/utility_process_host_impl.h"
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 virtual void OnProcessCrashed(int exit_code); 55 virtual void OnProcessCrashed(int exit_code);
56 virtual bool OnMessageReceived(const IPC::Message& message); 56 virtual bool OnMessageReceived(const IPC::Message& message);
57 57
58 // IPC message handlers 58 // IPC message handlers
59 void OnIDBKeysFromValuesAndKeyPathSucceeded( 59 void OnIDBKeysFromValuesAndKeyPathSucceeded(
60 int id, const std::vector<IndexedDBKey>& keys); 60 int id, const std::vector<IndexedDBKey>& keys);
61 void OnIDBKeysFromValuesAndKeyPathFailed(int id); 61 void OnIDBKeysFromValuesAndKeyPathFailed(int id);
62 void OnInjectIDBKeyFinished(const content::SerializedScriptValue& value); 62 void OnInjectIDBKeyFinished(const content::SerializedScriptValue& value);
63 63
64 private: 64 private:
65 virtual ~Client() {}
66
65 KeyUtilityClientImpl* parent_; 67 KeyUtilityClientImpl* parent_;
66 68
67 DISALLOW_COPY_AND_ASSIGN(Client); 69 DISALLOW_COPY_AND_ASSIGN(Client);
68 }; 70 };
69 71
70 friend class base::RefCountedThreadSafe<KeyUtilityClientImpl>; 72 friend class base::RefCountedThreadSafe<KeyUtilityClientImpl>;
71 ~KeyUtilityClientImpl(); 73 ~KeyUtilityClientImpl();
72 74
73 void GetRDHAndStartUtilityProcess(); 75 void GetRDHAndStartUtilityProcess();
74 void StartUtilityProcessInternal(); 76 void StartUtilityProcessInternal();
(...skipping 321 matching lines...) Expand 10 before | Expand all | Expand 10 after
396 void KeyUtilityClientImpl::Client::OnInjectIDBKeyFinished( 398 void KeyUtilityClientImpl::Client::OnInjectIDBKeyFinished(
397 const content::SerializedScriptValue& value) { 399 const content::SerializedScriptValue& value) {
398 parent_->SetValueAfterInjection(value); 400 parent_->SetValueAfterInjection(value);
399 parent_->FinishInjectingKey(); 401 parent_->FinishInjectingKey();
400 } 402 }
401 403
402 void KeyUtilityClientImpl::Client::OnIDBKeysFromValuesAndKeyPathFailed( 404 void KeyUtilityClientImpl::Client::OnIDBKeysFromValuesAndKeyPathFailed(
403 int id) { 405 int id) {
404 parent_->FinishCreatingKeys(); 406 parent_->FinishCreatingKeys();
405 } 407 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698