Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: content/browser/download/download_net_log_parameters.h

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: MSVC fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_net_log_parameters.h
diff --git a/content/browser/download/download_net_log_parameters.h b/content/browser/download/download_net_log_parameters.h
index c52b87e5bfab8444d2a065d4bdfc78b7a4b64e5b..5e0cf3083aed8c8ab730fc9978a789b75f3527d9 100644
--- a/content/browser/download/download_net_log_parameters.h
+++ b/content/browser/download/download_net_log_parameters.h
@@ -31,9 +31,11 @@ class ItemActivatedParameters : public net::NetLog::EventParameters {
content::DownloadDangerType danger_type,
content::DownloadItem::SafetyState safety_state,
int64 start_offset);
- virtual ~ItemActivatedParameters();
virtual base::Value* ToValue() const OVERRIDE;
+ protected:
+ virtual ~ItemActivatedParameters();
+
private:
const DownloadType type_;
const int64 id_;
@@ -54,6 +56,9 @@ class ItemCheckedParameters : public net::NetLog::EventParameters {
content::DownloadItem::SafetyState safety_state);
virtual base::Value* ToValue() const OVERRIDE;
+ protected:
+ virtual ~ItemCheckedParameters();
+
private:
const content::DownloadDangerType danger_type_;
const content::DownloadItem::SafetyState safety_state_;
@@ -67,6 +72,9 @@ class ItemInHistoryParameters : public net::NetLog::EventParameters {
ItemInHistoryParameters(int64 handle);
virtual base::Value* ToValue() const OVERRIDE;
+ protected:
+ virtual ~ItemInHistoryParameters();
+
private:
const int64 db_handle_;
@@ -79,6 +87,9 @@ class ItemUpdatedParameters : public net::NetLog::EventParameters {
ItemUpdatedParameters(int64 bytes_so_far);
virtual base::Value* ToValue() const OVERRIDE;
+ protected:
+ virtual ~ItemUpdatedParameters();
+
private:
const int64 bytes_so_far_;
@@ -92,6 +103,9 @@ class ItemRenamedParameters : public net::NetLog::EventParameters {
const std::string& old_filename, const std::string& new_filename);
virtual base::Value* ToValue() const OVERRIDE;
+ protected:
+ virtual ~ItemRenamedParameters();
+
private:
const std::string old_filename_;
const std::string new_filename_;
@@ -107,6 +121,9 @@ class ItemInterruptedParameters : public net::NetLog::EventParameters {
const std::string& hash_state);
virtual base::Value* ToValue() const OVERRIDE;
+ protected:
+ virtual ~ItemInterruptedParameters();
+
private:
const content::DownloadInterruptReason reason_;
const int64 bytes_so_far_;
@@ -121,6 +138,9 @@ class ItemFinishedParameters : public net::NetLog::EventParameters {
ItemFinishedParameters(int64 bytes_so_far, const std::string& final_hash);
virtual base::Value* ToValue() const OVERRIDE;
+ protected:
+ virtual ~ItemFinishedParameters();
+
private:
const int64 bytes_so_far_;
const std::string final_hash_;
@@ -134,6 +154,9 @@ class ItemCanceledParameters : public net::NetLog::EventParameters {
ItemCanceledParameters(int64 bytes_so_far, const std::string& hash_state);
virtual base::Value* ToValue() const OVERRIDE;
+ protected:
+ virtual ~ItemCanceledParameters();
+
private:
const int64 bytes_so_far_;
const std::string hash_state_;
@@ -148,6 +171,9 @@ class FileOpenedParameters : public net::NetLog::EventParameters {
int64 start_offset);
virtual base::Value* ToValue() const OVERRIDE;
+ protected:
+ virtual ~FileOpenedParameters();
+
private:
const std::string file_name_;
const int64 start_offset_;
@@ -162,6 +188,9 @@ class FileRenamedParameters : public net::NetLog::EventParameters {
const std::string& old_filename, const std::string& new_filename);
virtual base::Value* ToValue() const OVERRIDE;
+ protected:
+ virtual ~FileRenamedParameters();
+
private:
const std::string old_filename_;
const std::string new_filename_;
@@ -175,6 +204,9 @@ class FileErrorParameters : public net::NetLog::EventParameters {
FileErrorParameters(const std::string& operation, net::Error net_error);
virtual base::Value* ToValue() const OVERRIDE;
+ protected:
+ virtual ~FileErrorParameters();
+
private:
const std::string operation_;
const net::Error net_error_;
« no previous file with comments | « content/browser/device_orientation/provider_unittest.cc ('k') | content/browser/download/download_net_log_parameters.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698