content/browser/plugin_service_impl.cc - Issue 10068037: RefCounted types should not have public destructors, content/browser part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/plugin_service_impl.cc

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: MSVC fixes Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/plugin_service_impl.cc

diff --git a/content/browser/plugin_service_impl.cc b/content/browser/plugin_service_impl.cc

index 29909c240bd16c2ab3ccd46b2169f23912a3e3ec..e2391265242349d0fd124a1bb2b7f1487f0cd970 100644

--- a/content/browser/plugin_service_impl.cc

+++ b/content/browser/plugin_service_impl.cc

@@ -96,6 +96,9 @@ class PluginDirWatcherDelegate : public FilePathWatcher::Delegate {

// stopping the watcher would be enough. Or possibly restart it.

NOTREACHED();

}

+ protected:

+ virtual ~PluginDirWatcherDelegate() {}

};

#endif

« no previous file with comments | « content/browser/plugin_loader_posix_unittest.cc ('k') | content/browser/profiler_message_filter.h » ('j') | no next file with comments »