content/browser/renderer_host/pepper_message_filter.h - Issue 10068037: RefCounted types should not have public destructors, content/browser part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper_message_filter.h

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: MSVC fixes Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/pepper_file_message_filter.cc ('k') | content/browser/renderer_host/pepper_message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper_message_filter.h

diff --git a/content/browser/renderer_host/pepper_message_filter.h b/content/browser/renderer_host/pepper_message_filter.h

index 86577931e90e8426b2a2828345497022efcbf020..bace9d3199cd372b040ffd4b86c94406a65c9608 100644

--- a/content/browser/renderer_host/pepper_message_filter.h

+++ b/content/browser/renderer_host/pepper_message_filter.h

@@ -67,10 +67,7 @@ class PepperMessageFilter

// Constructor when used in the context of a PPAPI process (the argument is

// provided for sanity checking).

- explicit PepperMessageFilter(ProcessType type,

- net::HostResolver* host_resolver);

- virtual ~PepperMessageFilter();

+ PepperMessageFilter(ProcessType type, net::HostResolver* host_resolver);

// content::BrowserMessageFilter methods.

virtual void OverrideThreadForMessage(

@@ -99,6 +96,9 @@ class PepperMessageFilter

const net::SSLConfig& ssl_config() { return ssl_config_; }

+ protected:

+ virtual ~PepperMessageFilter();

private:

struct OnConnectTcpBoundInfo {

int routing_id;