Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 964553002: Remove support for special "sign in process" state. (Closed)

Created:
5 years, 10 months ago by Roger Tawa OOO till Jul 10th
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ocl3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support for special "sign in process" state. This was needed for one click sign in which is no longer used. https://codereview.chromium.org/959013002/ BUG=260022, 350202 Committed: https://crrev.com/cbd2bb442ec209b572babbced7b61ed76e9d1ba4 Cr-Commit-Position: refs/heads/master@{#321568}

Patch Set 1 #

Patch Set 2 : merged #

Patch Set 3 : Removed unused var #

Patch Set 4 : Remove uneeded test #

Patch Set 5 : Fix URLBlacklistManagerTest.DontBlockResources #

Patch Set 6 : git cl format #

Patch Set 7 : rebased #

Patch Set 8 : rebased #

Total comments: 3

Patch Set 9 : rebased #

Patch Set 10 : Remove unneeded headers #

Patch Set 11 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -472 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 6 7 chunks +0 lines, -65 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M chrome/browser/extensions/browser_permissions_policy_delegate.cc View 1 2 3 4 5 6 7 8 9 2 chunks +0 lines, -28 lines 0 comments Download
M chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc View 1 2 3 1 chunk +0 lines, -95 lines 0 comments Download
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/policy/policy_helpers.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/policy/url_blacklist_manager_unittest.cc View 1 2 3 4 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/signin/chrome_signin_client.h View 3 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/signin/chrome_signin_client.cc View 4 chunks +1 line, -47 lines 0 comments Download
M chrome/browser/signin/signin_manager_unittest.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 3 4 5 6 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/renderer/extensions/renderer_permissions_policy_delegate.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M components/signin/core/browser/signin_client.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/signin/core/browser/signin_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/signin/core/browser/signin_manager.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -32 lines 0 comments Download
M components/signin/core/browser/test_signin_client.h View 2 chunks +0 lines, -5 lines 0 comments Download
M components/signin/core/browser/test_signin_client.cc View 1 2 2 chunks +0 lines, -26 lines 0 comments Download
M extensions/browser/api/web_request/web_request_permissions.cc View 1 2 3 4 5 1 chunk +3 lines, -4 lines 0 comments Download
M extensions/browser/info_map.h View 2 chunks +0 lines, -7 lines 0 comments Download
M extensions/browser/info_map.cc View 1 2 3 4 5 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Roger Tawa OOO till Jul 10th
Hi Mike, Please take a look. Removes code that is no longer used. Thanks.
5 years, 9 months ago (2015-03-16 19:26:50 UTC) #5
Mike Lerman
On 2015/03/16 19:26:50, Roger Tawa wrote: > Hi Mike, > > Please take a look. ...
5 years, 9 months ago (2015-03-17 01:00:41 UTC) #6
Roger Tawa OOO till Jul 10th
Thanks Mike. I had the same question too. I'll see what the owner says.
5 years, 9 months ago (2015-03-17 12:18:13 UTC) #7
Roger Tawa OOO till Jul 10th
Hi Drew, Ken, Scott, Can you please take a look? Drew: Please review changes in ...
5 years, 9 months ago (2015-03-17 12:19:13 UTC) #9
sky
Said files LGTM
5 years, 9 months ago (2015-03-17 23:01:31 UTC) #10
Ken Rockot(use gerrit already)
extensions bits lgtm
5 years, 9 months ago (2015-03-17 23:16:36 UTC) #11
Andrew T Wilson (Slow)
Yay, no more special signin process goo! LGTM https://codereview.chromium.org/964553002/diff/200001/chrome/browser/extensions/browser_permissions_policy_delegate.cc File chrome/browser/extensions/browser_permissions_policy_delegate.cc (right): https://codereview.chromium.org/964553002/diff/200001/chrome/browser/extensions/browser_permissions_policy_delegate.cc#newcode14 chrome/browser/extensions/browser_permissions_policy_delegate.cc:14: #include ...
5 years, 9 months ago (2015-03-19 07:05:33 UTC) #12
Roger Tawa OOO till Jul 10th
Thanks Drew. https://codereview.chromium.org/964553002/diff/200001/chrome/browser/extensions/browser_permissions_policy_delegate.cc File chrome/browser/extensions/browser_permissions_policy_delegate.cc (right): https://codereview.chromium.org/964553002/diff/200001/chrome/browser/extensions/browser_permissions_policy_delegate.cc#newcode14 chrome/browser/extensions/browser_permissions_policy_delegate.cc:14: #include "chrome/browser/signin/chrome_signin_client.h" On 2015/03/19 07:05:33, Andrew T ...
5 years, 9 months ago (2015-03-19 21:19:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964553002/260001
5 years, 9 months ago (2015-03-20 14:37:30 UTC) #16
commit-bot: I haz the power
Committed patchset #11 (id:260001)
5 years, 9 months ago (2015-03-20 15:12:52 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 15:13:27 UTC) #18
Message was sent while issue was closed. 
Patchset 11 (id:??) landed as
https://crrev.com/cbd2bb442ec209b572babbced7b61ed76e9d1ba4
Cr-Commit-Position: refs/heads/master@{#321568}

Powered by Google App Engine
This is Rietveld 408576698