Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1490)

Unified Diff: chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc

Issue 964553002: Remove support for special "sign in process" state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ocl3
Patch Set: rebased Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc
index 5df284b55b63d5be0be834780a18ba36f29a8082..50278908f83fe53878a59678390565f9eb0147b7 100644
--- a/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc
@@ -95,8 +95,6 @@ TEST_F(ExtensionWebRequestHelpersTestWithThreadsTest, TestHideRequestForURL) {
const char* const non_sensitive_urls[] = {
"http://www.google.com/"
};
- const int kSigninProcessId = 99;
- extension_info_map_->SetSigninProcess(kSigninProcessId);
// Check that requests are rejected based on the destination
for (size_t i = 0; i < arraysize(sensitive_urls); ++i) {
@@ -145,25 +143,6 @@ TEST_F(ExtensionWebRequestHelpersTestWithThreadsTest, TestHideRequestForURL) {
EXPECT_TRUE(WebRequestPermissions::HideRequest(
extension_info_map_.get(), sensitive_request.get()));
}
- // If the process is the signin process, it becomes protected.
- {
- int process_id = kSigninProcessId;
- int view_id = 19;
- scoped_ptr<net::URLRequest> sensitive_request(context.CreateRequest(
- non_sensitive_url, net::DEFAULT_PRIORITY, NULL, NULL));
- ResourceRequestInfo::AllocateForTesting(sensitive_request.get(),
- content::RESOURCE_TYPE_SCRIPT,
- NULL,
- process_id,
- view_id,
- MSG_ROUTING_NONE,
- false, // is_main_frame
- false, // parent_is_main_frame
- true, // allow_download
- false); // is_async
- EXPECT_TRUE(WebRequestPermissions::HideRequest(
- extension_info_map_.get(), sensitive_request.get()));
- }
}
TEST_F(ExtensionWebRequestHelpersTestWithThreadsTest,
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/extensions/browser_permissions_policy_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698