Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: chrome/browser/extensions/browser_permissions_policy_delegate.cc

Issue 964553002: Remove support for special "sign in process" state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ocl3
Patch Set: rebased Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/browser_permissions_policy_delegate.cc
diff --git a/chrome/browser/extensions/browser_permissions_policy_delegate.cc b/chrome/browser/extensions/browser_permissions_policy_delegate.cc
index 322605ce353e82452e53118cb88e5cf06a825930..11df0d8a99698a07787724b4cdde54b71e789077 100644
--- a/chrome/browser/extensions/browser_permissions_policy_delegate.cc
+++ b/chrome/browser/extensions/browser_permissions_policy_delegate.cc
@@ -10,11 +10,6 @@
#include "content/public/browser/browser_thread.h"
#include "extensions/common/manifest_constants.h"
-#if !defined(OS_CHROMEOS)
-#include "chrome/browser/signin/chrome_signin_client.h"
-#include "chrome/browser/signin/chrome_signin_client_factory.h"
-#endif
-
namespace extensions {
namespace errors = manifest_errors;
@@ -34,29 +29,6 @@ bool BrowserPermissionsPolicyDelegate::CanExecuteScriptOnPage(
int process_id,
std::string* error) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
-
-#if !defined(OS_CHROMEOS)
- // NULL in unit tests.
- if (!g_browser_process->profile_manager())
- return true;
-
- // We don't have a Profile in this context. That's OK - for our purposes,
- // we can just check every Profile for its signin process. If any of them
- // match, block script access.
- std::vector<Profile*> profiles =
- g_browser_process->profile_manager()->GetLoadedProfiles();
- for (std::vector<Profile*>::iterator profile = profiles.begin();
- profile != profiles.end(); ++profile) {
- SigninClient* signin_client =
- ChromeSigninClientFactory::GetForProfile(*profile);
- if (signin_client && signin_client->IsSigninProcess(process_id)) {
- if (error)
- *error = errors::kCannotScriptSigninPage;
- return false;
- }
- }
-#endif
-
return true;
}

Powered by Google App Engine
This is Rietveld 408576698