Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc

Issue 964553002: Remove support for special "sign in process" state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ocl3
Patch Set: rebased Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc
diff --git a/chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc b/chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc
index c71ccb84598211125a53d116ab18a9bd625d0ad1..1889b87e918505366b04ada870cfc5055e1413d5 100644
--- a/chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc
+++ b/chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc
@@ -3,7 +3,6 @@
// found in the LICENSE file.
#include "base/command_line.h"
-#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.h"
#include "chrome/renderer/extensions/renderer_permissions_policy_delegate.h"
@@ -60,26 +59,6 @@ scoped_refptr<const Extension> CreateTestExtension(const std::string& id) {
} // namespace
-// Tests that CanAccessPage returns false for the signin process,
-// all else being equal.
-TEST_F(RendererPermissionsPolicyDelegateTest, CannotScriptSigninProcess) {
- GURL kSigninUrl(
- "https://accounts.google.com/ServiceLogin?service=chromiumsync");
- scoped_refptr<const Extension> extension(CreateTestExtension("a"));
- std::string error;
-
- EXPECT_TRUE(extension->permissions_data()->CanAccessPage(
- extension.get(), kSigninUrl, kSigninUrl, -1, -1, &error))
- << error;
- // Pretend we are in the signin process. We should not be able to execute
- // script.
- base::CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kSigninProcess);
- EXPECT_FALSE(extension->permissions_data()->CanAccessPage(
- extension.get(), kSigninUrl, kSigninUrl, -1, -1, &error))
- << error;
-}
-
// Tests that CanAccessPage returns false for the any process
// which hosts the webstore.
TEST_F(RendererPermissionsPolicyDelegateTest, CannotScriptWebstore) {
« no previous file with comments | « chrome/renderer/extensions/renderer_permissions_policy_delegate.cc ('k') | components/signin/core/browser/signin_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698