Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: components/signin/core/browser/signin_manager.cc

Issue 964553002: Remove support for special "sign in process" state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ocl3
Patch Set: rebased Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/signin_manager.cc
diff --git a/components/signin/core/browser/signin_manager.cc b/components/signin/core/browser/signin_manager.cc
index eb17cc61d573b997d32a8b642609f306c5f53f02..da47552712365d37ffaf9b77de7d33b38b69c0f2 100644
--- a/components/signin/core/browser/signin_manager.cc
+++ b/components/signin/core/browser/signin_manager.cc
@@ -23,42 +23,10 @@
#include "google_apis/gaia/gaia_auth_util.h"
#include "google_apis/gaia/gaia_constants.h"
#include "google_apis/gaia/gaia_urls.h"
-#include "net/base/escape.h"
#include "third_party/icu/source/i18n/unicode/regex.h"
using namespace signin_internals_util;
-namespace {
-
-const char kChromiumSyncService[] = "service=chromiumsync";
-
-} // namespace
-
-// Under the covers, we use a dummy chrome-extension ID to serve the purposes
-// outlined in the .h file comment for this string.
-const char SigninManager::kChromeSigninEffectiveSite[] =
- "chrome-extension://acfccoigjajmmgbhpfbjnpckhjjegnih";
-
-// static
-bool SigninManager::IsWebBasedSigninFlowURL(const GURL& url) {
- GURL effective(kChromeSigninEffectiveSite);
- if (url.SchemeIs(effective.scheme().c_str()) &&
- url.host() == effective.host()) {
- return true;
- }
-
- GURL service_login(GaiaUrls::GetInstance()->service_login_url());
- if (url.GetOrigin() != service_login.GetOrigin())
- return false;
-
- // Any login UI URLs with signin=chromiumsync should be considered a web
- // URL (relies on GAIA keeping the "service=chromiumsync" query string
- // fragment present even when embedding inside a "continue" parameter).
- return net::UnescapeURLComponent(url.query(),
- net::UnescapeRule::URL_SPECIAL_CHARS)
- .find(kChromiumSyncService) != std::string::npos;
-}
-
SigninManager::SigninManager(SigninClient* client,
ProfileOAuth2TokenService* token_service,
AccountTrackerService* account_tracker_service)
« no previous file with comments | « components/signin/core/browser/signin_manager.h ('k') | components/signin/core/browser/test_signin_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698