Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: chrome/browser/signin/chrome_signin_client.h

Issue 964553002: Remove support for special "sign in process" state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ocl3
Patch Set: rebased Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/chrome_signin_client.h
diff --git a/chrome/browser/signin/chrome_signin_client.h b/chrome/browser/signin/chrome_signin_client.h
index 2251d974dda2b6f3b89aebbd7f72c1c601bb4b29..358150fc7292c9b60860322b90f0a5c9382bd2a3 100644
--- a/chrome/browser/signin/chrome_signin_client.h
+++ b/chrome/browser/signin/chrome_signin_client.h
@@ -9,13 +9,11 @@
#include "base/compiler_specific.h"
#include "components/signin/core/browser/signin_client.h"
#include "components/signin/core/browser/signin_error_controller.h"
-#include "content/public/browser/render_process_host_observer.h"
class CookieSettings;
class Profile;
class ChromeSigninClient : public SigninClient,
- public content::RenderProcessHostObserver,
public SigninErrorController::Observer {
public:
explicit ChromeSigninClient(
@@ -26,22 +24,6 @@ class ChromeSigninClient : public SigninClient,
static bool ProfileAllowsSigninCookies(Profile* profile);
static bool SettingsAllowSigninCookies(CookieSettings* cookie_settings);
- // Tracks the privileged signin process identified by |host_id| so that we
- // can later ask (via IsSigninProcess) if it is safe to sign the user in from
- // the current context (see OneClickSigninHelper). All of this tracking
- // state is reset once the renderer process terminates.
- //
- // N.B. This is the id returned by RenderProcessHost::GetID().
- // TODO(guohui): Eliminate these APIs once the web-based signin flow is
- // replaced by a native flow. crbug.com/347247
- void SetSigninProcess(int host_id) override;
- void ClearSigninProcess() override;
- bool IsSigninProcess(int host_id) const override;
- bool HasSigninProcess() const override;
-
- // content::RenderProcessHostObserver implementation.
- void RenderProcessHostDestroyed(content::RenderProcessHost* host) override;
-
// SigninClient implementation.
PrefService* GetPrefs() override;
scoped_refptr<TokenWebData> GetDatabase() override;
@@ -81,13 +63,6 @@ class ChromeSigninClient : public SigninClient,
SigninErrorController* signin_error_controller_;
- // See SetSigninProcess. Tracks the currently active signin process
- // by ID, if there is one.
- int signin_host_id_;
-
- // The RenderProcessHosts being observed.
- std::set<content::RenderProcessHost*> signin_hosts_observed_;
-
DISALLOW_COPY_AND_ASSIGN(ChromeSigninClient);
};
« no previous file with comments | « chrome/browser/policy/url_blacklist_manager_unittest.cc ('k') | chrome/browser/signin/chrome_signin_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698