Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 959013002: Remove support in ProfileIOData for one click sign in which is no longer used. (Closed)

Created:
5 years, 10 months ago by Roger Tawa OOO till Jul 10th
Modified:
5 years, 9 months ago
Reviewers:
Mike Lerman, mmenke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@ocl2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support in ProfileIOData for one click sign in which is no longer used. Depends on https://codereview.chromium.org/914363003/ BUG=260022, 350202 Committed: https://crrev.com/4558271aa1937dc793c20c079f2f01534b258de8 Cr-Commit-Position: refs/heads/master@{#320697}

Patch Set 1 : Fix browser tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -58 lines) Patch
M chrome/browser/profiles/profile_io_data.h View 2 chunks +0 lines, -33 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M chrome/browser/signin/signin_header_helper.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Roger Tawa OOO till Jul 10th
Hi Matt, Can you please take a look? Removing code that is no longer used. ...
5 years, 9 months ago (2015-03-09 21:09:55 UTC) #4
Roger Tawa OOO till Jul 10th
Hi Matt, Please take a look. Removing unused code. google_services_username() is non-empty when google_services_account_id() is ...
5 years, 9 months ago (2015-03-13 23:26:51 UTC) #8
mmenke
On 2015/03/13 23:26:51, Roger Tawa wrote: > Hi Matt, > > Please take a look. ...
5 years, 9 months ago (2015-03-13 23:38:22 UTC) #9
Roger Tawa OOO till Jul 10th
Hi Mike, Can you look at signin_header_helper.cc? google_services_username() is non-empty when google_services_account_id() is non-empty, so ...
5 years, 9 months ago (2015-03-14 23:11:09 UTC) #11
Mike Lerman
On 2015/03/14 23:11:09, Roger Tawa wrote: > Hi Mike, > > Can you look at ...
5 years, 9 months ago (2015-03-16 01:01:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959013002/100001
5 years, 9 months ago (2015-03-16 01:31:48 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:100001)
5 years, 9 months ago (2015-03-16 03:46:43 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 03:47:14 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4558271aa1937dc793c20c079f2f01534b258de8
Cr-Commit-Position: refs/heads/master@{#320697}

Powered by Google App Engine
This is Rietveld 408576698